mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2025-12-24 11:00:11 +01:00
panfrost: Unit test early-ZS helpers
The new early-ZS helpers are pure functions, leaf nodes of the call graph, and implemented with a different algorithm from the "oracle" table of correct values for various combinations of states. Further, incorrect settings often still pass CTS while causing game bugs or inefficiencies. That combination makes the helpers an excellent candidate for unit tests. Add some. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17428>
This commit is contained in:
Alyssa Rosenzweig
Marge Bot
parent
e96292bc07
commit
fe875c0144
2 changed files with 147 additions and 2 deletions
|
|
@ -132,10 +132,11 @@ if with_tests
|
|||
)
|
||||
|
||||
test(
|
||||
'panfrost_layout',
|
||||
'panfrost_tests',
|
||||
executable(
|
||||
'panfrost_layout',
|
||||
'panfrost_tests',
|
||||
files(
|
||||
'tests/test-earlyzs.cpp',
|
||||
'tests/test-layout.cpp',
|
||||
),
|
||||
c_args : [c_msvc_compat_args, no_override_init_args],
|
||||
|
|
|
|||
144
src/panfrost/lib/tests/test-earlyzs.cpp
Normal file
144
src/panfrost/lib/tests/test-earlyzs.cpp
Normal file
|
|
@ -0,0 +1,144 @@
|
|||
/*
|
||||
* Copyright (C) 2022 Collabora, Ltd.
|
||||
*
|
||||
* Permission is hereby granted, free of charge, to any person obtaining a
|
||||
* copy of this software and associated documentation files (the "Software"),
|
||||
* to deal in the Software without restriction, including without limitation
|
||||
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
||||
* and/or sell copies of the Software, and to permit persons to whom the
|
||||
* Software is furnished to do so, subject to the following conditions:
|
||||
*
|
||||
* The above copyright notice and this permission notice (including the next
|
||||
* paragraph) shall be included in all copies or substantial portions of the
|
||||
* Software.
|
||||
*
|
||||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
||||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
||||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
||||
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
||||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
||||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
||||
* SOFTWARE.
|
||||
*/
|
||||
|
||||
#include "pan_earlyzs.h"
|
||||
#include "util/pan_ir.h"
|
||||
|
||||
#include <gtest/gtest.h>
|
||||
|
||||
/*
|
||||
* Test the early-ZS helpers used on Bifrost and Valhall. Early-ZS state depends
|
||||
* on both shader state and draw-time API state. As such, there are two helpers
|
||||
* -- analzye and get -- that separate the link-time analysis of a fragment
|
||||
* shader from the draw-time classification. The internal data structure is not
|
||||
* under test, only the external API. So we test only the composition.
|
||||
*/
|
||||
|
||||
#define ZS_WRITEMASK BITFIELD_BIT(0)
|
||||
#define ALPHA2COV BITFIELD_BIT(1)
|
||||
#define ZS_ALWAYS_PASSES BITFIELD_BIT(2)
|
||||
#define DISCARD BITFIELD_BIT(3)
|
||||
#define WRITES_Z BITFIELD_BIT(4)
|
||||
#define WRITES_S BITFIELD_BIT(5)
|
||||
#define WRITES_COV BITFIELD_BIT(6)
|
||||
#define SIDEFX BITFIELD_BIT(7)
|
||||
#define API_EARLY BITFIELD_BIT(8)
|
||||
|
||||
static void
|
||||
test(enum pan_earlyzs expected_update, enum pan_earlyzs expected_kill, uint32_t flags)
|
||||
{
|
||||
struct pan_shader_info info = {
|
||||
.fs = {
|
||||
.can_discard = !!(flags & DISCARD),
|
||||
.writes_depth = !!(flags & WRITES_Z),
|
||||
.writes_stencil = !!(flags & WRITES_S),
|
||||
.writes_coverage = !!(flags & WRITES_COV),
|
||||
.early_fragment_tests = !!(flags & API_EARLY),
|
||||
},
|
||||
.writes_global = !!(flags & SIDEFX),
|
||||
};
|
||||
|
||||
struct pan_earlyzs_state result =
|
||||
pan_earlyzs_get(pan_earlyzs_analyze(&info),
|
||||
!!(flags & ZS_WRITEMASK),
|
||||
!!(flags & ALPHA2COV),
|
||||
!!(flags & ZS_ALWAYS_PASSES));
|
||||
|
||||
ASSERT_EQ(result.update, expected_update);
|
||||
ASSERT_EQ(result.kill, expected_kill);
|
||||
}
|
||||
|
||||
|
||||
#define CASE(expected_update, expected_kill, flags) \
|
||||
test(PAN_EARLYZS_ ## expected_update, PAN_EARLYZS_ ## expected_kill, flags)
|
||||
|
||||
TEST(EarlyZS, APIForceEarly)
|
||||
{
|
||||
CASE(FORCE_EARLY, FORCE_EARLY, API_EARLY);
|
||||
CASE(FORCE_EARLY, FORCE_EARLY, API_EARLY | WRITES_Z | WRITES_S);
|
||||
CASE(FORCE_EARLY, FORCE_EARLY, API_EARLY | ALPHA2COV | DISCARD);
|
||||
}
|
||||
|
||||
TEST(EarlyZS, ShaderCalculatesZS)
|
||||
{
|
||||
CASE(FORCE_LATE, FORCE_LATE, WRITES_Z);
|
||||
CASE(FORCE_LATE, FORCE_LATE, WRITES_S);
|
||||
CASE(FORCE_LATE, FORCE_LATE, WRITES_Z | WRITES_S);
|
||||
CASE(FORCE_LATE, FORCE_LATE, WRITES_Z | WRITES_S | SIDEFX);
|
||||
CASE(FORCE_LATE, FORCE_LATE, WRITES_Z | WRITES_S | ZS_ALWAYS_PASSES);
|
||||
CASE(FORCE_LATE, FORCE_LATE, WRITES_Z | ZS_ALWAYS_PASSES | ALPHA2COV);
|
||||
}
|
||||
|
||||
TEST(EarlyZS, ModifiesCoverageWritesZSNoSideFX)
|
||||
{
|
||||
CASE(FORCE_LATE, FORCE_EARLY, ZS_WRITEMASK | WRITES_COV);
|
||||
CASE(FORCE_LATE, FORCE_EARLY, ZS_WRITEMASK | DISCARD);
|
||||
CASE(FORCE_LATE, FORCE_EARLY, ZS_WRITEMASK | ALPHA2COV);
|
||||
CASE(FORCE_LATE, FORCE_EARLY, ZS_WRITEMASK | WRITES_COV | DISCARD | ALPHA2COV);
|
||||
}
|
||||
|
||||
TEST(EarlyZS, ModifiesCoverageWritesZSNoSideFXAlt)
|
||||
{
|
||||
CASE(FORCE_LATE, WEAK_EARLY, ZS_ALWAYS_PASSES | ZS_WRITEMASK | WRITES_COV);
|
||||
CASE(FORCE_LATE, WEAK_EARLY, ZS_ALWAYS_PASSES | ZS_WRITEMASK | DISCARD);
|
||||
CASE(FORCE_LATE, WEAK_EARLY, ZS_ALWAYS_PASSES | ZS_WRITEMASK | ALPHA2COV);
|
||||
CASE(FORCE_LATE, WEAK_EARLY, ZS_ALWAYS_PASSES | ZS_WRITEMASK | WRITES_COV | DISCARD | ALPHA2COV);
|
||||
}
|
||||
|
||||
TEST(EarlyZS, ModifiesCoverageWritesZSSideFX)
|
||||
{
|
||||
CASE(FORCE_LATE, FORCE_LATE, ZS_WRITEMASK | SIDEFX | WRITES_COV);
|
||||
CASE(FORCE_LATE, FORCE_LATE, ZS_WRITEMASK | SIDEFX | DISCARD);
|
||||
CASE(FORCE_LATE, FORCE_LATE, ZS_WRITEMASK | SIDEFX | ALPHA2COV);
|
||||
CASE(FORCE_LATE, FORCE_LATE, ZS_WRITEMASK | SIDEFX | WRITES_COV | DISCARD | ALPHA2COV);
|
||||
}
|
||||
|
||||
TEST(EarlyZS, SideFXNoShaderZS)
|
||||
{
|
||||
CASE(FORCE_EARLY, FORCE_LATE, SIDEFX);
|
||||
CASE(FORCE_EARLY, FORCE_LATE, SIDEFX | DISCARD);
|
||||
CASE(FORCE_EARLY, FORCE_LATE, SIDEFX | WRITES_COV);
|
||||
CASE(FORCE_EARLY, FORCE_LATE, SIDEFX | ALPHA2COV);
|
||||
}
|
||||
|
||||
TEST(EarlyZS, SideFXNoShaderZSAlt)
|
||||
{
|
||||
CASE(WEAK_EARLY, FORCE_LATE, ZS_ALWAYS_PASSES | SIDEFX);
|
||||
CASE(WEAK_EARLY, FORCE_LATE, ZS_ALWAYS_PASSES | SIDEFX | DISCARD);
|
||||
CASE(WEAK_EARLY, FORCE_LATE, ZS_ALWAYS_PASSES | SIDEFX | WRITES_COV);
|
||||
CASE(WEAK_EARLY, FORCE_LATE, ZS_ALWAYS_PASSES | SIDEFX | ALPHA2COV);
|
||||
}
|
||||
|
||||
TEST(EarlyZS, NoSideFXNoShaderZS)
|
||||
{
|
||||
CASE(FORCE_EARLY, FORCE_EARLY, 0);
|
||||
CASE(FORCE_EARLY, FORCE_EARLY, ALPHA2COV | DISCARD | WRITES_COV);
|
||||
CASE(FORCE_EARLY, FORCE_EARLY, ZS_WRITEMASK);
|
||||
}
|
||||
|
||||
TEST(EarlyZS, NoSideFXNoShaderZSAlt)
|
||||
{
|
||||
CASE(WEAK_EARLY, WEAK_EARLY, ZS_ALWAYS_PASSES);
|
||||
CASE(WEAK_EARLY, WEAK_EARLY, ZS_ALWAYS_PASSES | ALPHA2COV | DISCARD | WRITES_COV);
|
||||
CASE(WEAK_EARLY, WEAK_EARLY, ZS_ALWAYS_PASSES | ZS_WRITEMASK);
|
||||
}
|
||||
Loading…
Add table
Reference in a new issue