fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 09:08:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

radeonsi: re-enable fp16_rtz for compute blits to fix PBO tests on gfx11

Browse source 
Fixes: bcdde99675 - radeonsi: don't convert to fp16 in the compute blit if not testing

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23216>
(cherry picked from commit 264cf37348)
This commit is contained in:
Marek Olšák 2023-05-19 03:09:53 -04:00 • committed by Eric Engestrom
parent 63b4c80c90
commit 1794199bf8
2 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -2137,7 +2137,7 @@
"description": "radeonsi: re-enable fp16_rtz for compute blits to fix PBO tests on gfx11",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "bcdde99675d2721e30c2cdda4c7c964dc69c1cda"
},

11
src/gallium/drivers/radeonsi/si_compute_blit.c
View file

@ -1159,14 +1159,15 @@ bool si_compute_blit(struct si_context *sctx, const struct pipe_blit_info *info,
options.last_src_channel < options.last_dst_channel &&
options.last_dst_channel == 3;
/* WARNING: We only use this codepath for AMD_TEST to get results identical with the gfx blit,
/* WARNING: We need this option for AMD_TEST to get results identical with the gfx blit,
* otherwise we wouldn't be able to fully validate whether everything else works.
* The test expects that the behavior is identical to u_blitter.
*
* Additionally, we need to keep this enabled even when not testing because not doing fp16_rtz
* breaks "piglit/bin/texsubimage -auto pbo".
*/
if (testing) {
options.fp16_rtz = !util_format_is_pure_integer(info->dst.format) &&
dst_desc->channel[i].size <= 10;
}
options.fp16_rtz = !util_format_is_pure_integer(info->dst.format) &&
dst_desc->channel[i].size <= 10;
struct hash_entry *entry = _mesa_hash_table_search(sctx->cs_blit_shaders,
(void*)(uintptr_t)options.key);