fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 04:48:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

util/half: Stop whacking CPU flags to test float_to_half_slow()

Browse source 
Smashing bits is super sketchy.  However, all the bits do is force the
test down the _slow path so let's explicitly test that instead.

Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41295>
This commit is contained in:
Faith Ekstrand 2026-05-05 14:13:44 -04:00 • committed by Marge Bot
parent 9bf392b67b
commit 0e063c5deb
1 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/util/tests/half_float_test.cpp
View file

@ -137,7 +137,7 @@ test_float_to_half_limits(uint16_t (*func)(float))
}
static void
u_half_test_test(void)
test_float_to_half_roundtrip(uint16_t (*func)(float))
{
unsigned i;
unsigned roundtrip_fails = 0;
@ -149,7 +149,7 @@ u_half_test_test(void)
uint16_t rh;
f.f = _mesa_half_to_float(h);
rh = _mesa_float_to_half(f.f);
rh = func(f.f);
if (h != rh && !(util_is_half_nan(h) && util_is_half_nan(rh))) {
printf("Roundtrip failed: %x -> %x = %f -> %x\n", h, f.ui, f.f, rh);
@ -162,13 +162,8 @@ u_half_test_test(void)
TEST(u_half_test, u_half_test)
{
u_half_test_test();
/* Test non-f16c. */
if (util_get_cpu_caps()->has_f16c) {
((struct util_cpu_caps_t *)util_get_cpu_caps())->has_f16c = false;
u_half_test_test();
}
test_float_to_half_roundtrip(_mesa_float_to_half);
test_float_to_half_roundtrip(_mesa_float_to_half_slow);
}
TEST(float_to_half_test, float_to_half_test)