fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 19:58:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

zink: fix incorrect line mode check for bresenham

Browse source 
the line requirement check logic was assuming mode index 0
is bresenhamLines, but it is actually rectangularLines.

cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22575>
(cherry picked from commit f6b5e128c1)
This commit is contained in:
SoroushIMG 2023-02-16 09:43:40 +00:00 • committed by Eric Engestrom
parent be2ee5a9db
commit 089e14d4e9
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -283,7 +283,7 @@
"description": "zink: fix incorrect line mode check for bresenham", "description": "zink: fix incorrect line mode check for bresenham",
"nominated": true, "nominated": true,
"nomination_type": 0, "nomination_type": 0,
"resolution": 0, "resolution": 1,
"main_sha": null, "main_sha": null,
"because_sha": null "because_sha": null
}, },

4
src/gallium/drivers/zink/zink_pipeline.c
View file

@ -307,9 +307,9 @@ zink_create_gfx_pipeline(struct zink_screen *screen,
/* non-strictLine default lines are either parallelogram or bresenham which while not in GL spec, /* non-strictLine default lines are either parallelogram or bresenham which while not in GL spec,
* in practice end up being within the two-pixel exception in the GL spec. * in practice end up being within the two-pixel exception in the GL spec.
*/ */
else if (mode_idx || screen->info.props.limits.strictLines) else if ((mode_idx != 1) || screen->info.props.limits.strictLines)
warn_missing_feature(warned[mode_idx], features[hw_rast_state->line_mode][0]); warn_missing_feature(warned[mode_idx], features[hw_rast_state->line_mode][0]);
} else if (mode_idx || screen->info.props.limits.strictLines) } else if ((mode_idx != 1) || screen->info.props.limits.strictLines)
warn_missing_feature(warned[mode_idx], features[hw_rast_state->line_mode][hw_rast_state->line_stipple_enable]); warn_missing_feature(warned[mode_idx], features[hw_rast_state->line_mode][hw_rast_state->line_stipple_enable]);
} }