2010-04-16 16:43:47 -07:00
|
|
|
/*
|
|
|
|
|
* Copyright © 2010 Intel Corporation
|
|
|
|
|
*
|
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
|
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
|
|
|
* to deal in the Software without restriction, including without limitation
|
|
|
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
|
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
|
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
|
|
|
*
|
|
|
|
|
* The above copyright notice and this permission notice (including the next
|
|
|
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
|
|
|
* Software.
|
|
|
|
|
*
|
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
|
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
|
|
|
* DEALINGS IN THE SOFTWARE.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
/**
|
2010-11-17 10:43:10 -08:00
|
|
|
* \file opt_dead_code.cpp
|
2010-04-16 16:43:47 -07:00
|
|
|
*
|
|
|
|
|
* Eliminates dead assignments and variable declarations from the code.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include "ir.h"
|
|
|
|
|
#include "ir_visitor.h"
|
2010-07-30 16:05:27 -07:00
|
|
|
#include "ir_variable_refcount.h"
|
2010-04-16 16:43:47 -07:00
|
|
|
#include "glsl_types.h"
|
|
|
|
|
|
2010-08-05 12:07:23 -07:00
|
|
|
static bool debug = false;
|
|
|
|
|
|
2010-04-16 16:43:47 -07:00
|
|
|
/**
|
|
|
|
|
* Do a dead code pass over instructions and everything that instructions
|
|
|
|
|
* references.
|
|
|
|
|
*
|
|
|
|
|
* Note that this will remove assignments to globals, so it is not suitable
|
|
|
|
|
* for usage on an unlinked instruction stream.
|
|
|
|
|
*/
|
|
|
|
|
bool
|
2011-10-21 11:17:39 -07:00
|
|
|
do_dead_code(exec_list *instructions, bool uniform_locations_assigned)
|
2010-04-16 16:43:47 -07:00
|
|
|
{
|
2010-07-30 16:05:27 -07:00
|
|
|
ir_variable_refcount_visitor v;
|
2010-04-16 16:43:47 -07:00
|
|
|
bool progress = false;
|
|
|
|
|
|
2010-05-14 12:41:22 -07:00
|
|
|
v.run(instructions);
|
2010-04-16 16:43:47 -07:00
|
|
|
|
|
|
|
|
foreach_iter(exec_list_iterator, iter, v.variable_list) {
|
2012-01-28 16:58:37 -08:00
|
|
|
ir_variable_refcount_entry *entry = (ir_variable_refcount_entry *)iter.get();
|
2010-04-16 16:43:47 -07:00
|
|
|
|
2010-05-14 12:41:22 -07:00
|
|
|
/* Since each assignment is a reference, the refereneced count must be
|
|
|
|
|
* greater than or equal to the assignment count. If they are equal,
|
|
|
|
|
* then all of the references are assignments, and the variable is
|
|
|
|
|
* dead.
|
|
|
|
|
*
|
|
|
|
|
* Note that if the variable is neither assigned nor referenced, both
|
|
|
|
|
* counts will be zero and will be caught by the equality test.
|
|
|
|
|
*/
|
|
|
|
|
assert(entry->referenced_count >= entry->assigned_count);
|
|
|
|
|
|
2010-08-05 12:07:23 -07:00
|
|
|
if (debug) {
|
|
|
|
|
printf("%s@%p: %d refs, %d assigns, %sdeclared in our scope\n",
|
2010-08-11 14:04:51 -06:00
|
|
|
entry->var->name, (void *) entry->var,
|
2010-08-05 12:07:23 -07:00
|
|
|
entry->referenced_count, entry->assigned_count,
|
|
|
|
|
entry->declaration ? "" : "not ");
|
|
|
|
|
}
|
|
|
|
|
|
2010-05-14 12:41:22 -07:00
|
|
|
if ((entry->referenced_count > entry->assigned_count)
|
|
|
|
|
|| !entry->declaration)
|
2010-04-16 16:43:47 -07:00
|
|
|
continue;
|
|
|
|
|
|
|
|
|
|
if (entry->assign) {
|
|
|
|
|
/* Remove a single dead assignment to the variable we found.
|
|
|
|
|
* Don't do so if it's a shader output, though.
|
|
|
|
|
*/
|
2010-08-04 20:33:57 -07:00
|
|
|
if (entry->var->mode != ir_var_out &&
|
glsl: Convert ir_call to be a statement rather than a value.
Aside from ir_call, our IR is cleanly split into two classes:
- Statements (typeless; used for side effects, control flow)
- Values (deeply nestable, pure, typed expression trees)
Unfortunately, ir_call confused all this:
- For void functions, we placed ir_call directly in the instruction
stream, treating it as an untyped statement. Yet, it was a subclass
of ir_rvalue, and no other ir_rvalue could be used in this way.
- For functions with a return value, ir_call could be placed in
arbitrary expression trees. While this fit naturally with the source
language, it meant that expressions might not be pure, making it
difficult to transform and optimize them. To combat this, we always
emitted ir_call directly in the RHS of an ir_assignment, only using
a temporary variable in expression trees. Many passes relied on this
assumption; the acos and atan built-ins violated it.
This patch makes ir_call a statement (ir_instruction) rather than a
value (ir_rvalue). Non-void calls now take a ir_dereference of a
variable, and store the return value there---effectively a call and
assignment rolled into one. They cannot be embedded in expressions.
All expression trees are now pure, without exception.
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
2012-03-20 15:56:37 -07:00
|
|
|
entry->var->mode != ir_var_inout) {
|
2010-04-16 16:43:47 -07:00
|
|
|
entry->assign->remove();
|
|
|
|
|
progress = true;
|
2010-08-05 12:07:23 -07:00
|
|
|
|
|
|
|
|
if (debug) {
|
|
|
|
|
printf("Removed assignment to %s@%p\n",
|
2010-08-11 14:04:51 -06:00
|
|
|
entry->var->name, (void *) entry->var);
|
2010-08-05 12:07:23 -07:00
|
|
|
}
|
2010-04-16 16:43:47 -07:00
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
/* If there are no assignments or references to the variable left,
|
|
|
|
|
* then we can remove its declaration.
|
|
|
|
|
*/
|
2010-08-24 15:30:42 -07:00
|
|
|
|
|
|
|
|
/* uniform initializers are precious, and could get used by another
|
2011-10-21 11:17:39 -07:00
|
|
|
* stage. Also, once uniform locations have been assigned, the
|
|
|
|
|
* declaration cannot be deleted.
|
2012-05-01 14:26:09 -07:00
|
|
|
*
|
|
|
|
|
* Also, GL_ARB_uniform_buffer_object says that std140
|
|
|
|
|
* uniforms will not be eliminated. Since we always do
|
|
|
|
|
* std140, just don't eliminate uniforms in UBOs.
|
2010-08-24 15:30:42 -07:00
|
|
|
*/
|
|
|
|
|
if (entry->var->mode == ir_var_uniform &&
|
2012-05-01 14:26:09 -07:00
|
|
|
(uniform_locations_assigned ||
|
|
|
|
|
entry->var->constant_value ||
|
|
|
|
|
entry->var->uniform_block != -1))
|
2010-08-24 15:30:42 -07:00
|
|
|
continue;
|
|
|
|
|
|
2010-04-16 16:43:47 -07:00
|
|
|
entry->var->remove();
|
|
|
|
|
progress = true;
|
2010-08-05 12:07:23 -07:00
|
|
|
|
|
|
|
|
if (debug) {
|
|
|
|
|
printf("Removed declaration of %s@%p\n",
|
2010-08-11 14:04:51 -06:00
|
|
|
entry->var->name, (void *) entry->var);
|
2010-08-05 12:07:23 -07:00
|
|
|
}
|
2010-04-16 16:43:47 -07:00
|
|
|
}
|
|
|
|
|
}
|
2010-07-27 11:28:26 -07:00
|
|
|
|
2010-04-16 16:43:47 -07:00
|
|
|
return progress;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Does a dead code pass on the functions present in the instruction stream.
|
|
|
|
|
*
|
|
|
|
|
* This is suitable for use while the program is not linked, as it will
|
|
|
|
|
* ignore variable declarations (and the assignments to them) for variables
|
|
|
|
|
* with global scope.
|
|
|
|
|
*/
|
|
|
|
|
bool
|
2010-07-27 11:28:26 -07:00
|
|
|
do_dead_code_unlinked(exec_list *instructions)
|
2010-04-16 16:43:47 -07:00
|
|
|
{
|
|
|
|
|
bool progress = false;
|
|
|
|
|
|
|
|
|
|
foreach_iter(exec_list_iterator, iter, *instructions) {
|
|
|
|
|
ir_instruction *ir = (ir_instruction *)iter.get();
|
2010-04-21 16:02:15 -07:00
|
|
|
ir_function *f = ir->as_function();
|
|
|
|
|
if (f) {
|
|
|
|
|
foreach_iter(exec_list_iterator, sigiter, *f) {
|
|
|
|
|
ir_function_signature *sig =
|
|
|
|
|
(ir_function_signature *) sigiter.get();
|
2011-10-21 11:17:39 -07:00
|
|
|
/* The setting of the uniform_locations_assigned flag here is
|
|
|
|
|
* irrelevent. If there is a uniform declaration encountered
|
|
|
|
|
* inside the body of the function, something has already gone
|
|
|
|
|
* terribly, terribly wrong.
|
|
|
|
|
*/
|
|
|
|
|
if (do_dead_code(&sig->body, false))
|
2010-04-21 16:02:15 -07:00
|
|
|
progress = true;
|
|
|
|
|
}
|
2010-04-16 16:43:47 -07:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return progress;
|
|
|
|
|
}
|