The goodixmoc driver's verify state machine was missing a WAIT_FINGER_UP state between IDENTIFY and PWR_BTN_SHIELD_OFF. After the sensor reported a match/no-match result, the driver immediately completed the verify operation without waiting for the finger to be lifted from the sensor. This caused problems when fprintd retried verification after a no-match: the finger was still on the sensor, so the same (wrong) finger was scanned again instantly. On fast match-on-chip readers, all retry attempts could be exhausted in under a second, giving the user no time to reposition their finger. Add GOODIX_VERIFY_WAIT_FINGER_UP to the verify state machine, mirroring the existing GOODIX_ENROLL_WAIT_FINGER_UP in the enroll flow. The new state sends MOC_CMD0_FINGER_MODE / MOC_CMD1_SET_FINGER_UP to the sensor and waits for the finger to be removed before advancing to PWR_BTN_SHIELD_OFF. The callback handles the same cases as the enroll equivalent: - Timeout (5s): retry the finger-up wait - Protocol error: fail the SSM - Success: clear FINGER_STATUS_PRESENT and advance Link: https://gitlab.freedesktop.org/libfprint/fprintd/-/issues/209 |
||
|---|---|---|
| .ci | ||
| .gitlab-ci | ||
| data | ||
| demo | ||
| doc | ||
| examples | ||
| libfprint | ||
| scripts | ||
| tests | ||
| .git-blame-ignore-revs | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| AUTHORS | ||
| code-of-conduct.md | ||
| COPYING | ||
| gcovr.cfg | ||
| HACKING.md | ||
| INSTALL | ||
| MAINTAINERS | ||
| meson.build | ||
| meson_options.txt | ||
| NEWS | ||
| README.md | ||
| THANKS | ||
History
LibFPrint was originally developed as part of an academic project at the University Of Manchester.
It aimed to hide the differences between consumer fingerprint scanners and provide a single uniform API to application developers.
Goal
The ultimate goal of the FPrint project is to make fingerprint scanners widely and easily usable under common Linux environments.
License
Section 6 of the license states that for compiled works that use
this library, such works must include LibFPrint copyright notices
alongside the copyright notices for the other parts of the work.
LibFPrint includes code from NIST's NBIS software distribution.
We include Bozorth3 from the US Export Controlled distribution, which we have determined to be fine being shipped in an open source project.
Get in touch
- IRC -
#fprint@irc.oftc.net - Matrix -
#fprint:matrix.orgbridged to the IRC channel - MailingList - low traffic, not much used these days