Commit graph

2358 commits

Author SHA1 Message Date
Marcus Brinkmann
b9330ba780 Do not use DBUS_WIN in a public header file, use _WIN32. 2010-03-19 20:12:00 +01:00
Marcus Brinkmann
a127633f13 Define dbus_1_EXPORTS when appropriate. 2010-03-19 20:11:55 +01:00
Marcus Brinkmann
dbecdeabb2 Consistently include <config.h> in all C source files and never in header files. 2010-03-19 20:11:48 +01:00
Will Thompson
6663cb5dcf Dispatch post-activation messages to anyone interested
Previously, if a method call activated a service, it would only be
delivered to that service, and not to other services with match rules
which should match. This patch replaces the improperly-duplicated
dispatch code in activation.c with a call back into the normal dispatch
code, fixing this bug (fd.o#26427).

(Additionally, were one to service-activate a service that doesn't
understand file descriptors with a message containing a file descriptor,
the previous code would send it anyway, and the service's dbus library
would blow up. This is also fixed here, since the normal dispatch code
checks this correctly.)
2010-03-19 17:48:00 +00:00
Will Thompson
3a2753e667 Move dispatching to destination to bus_dispatch_matches() 2010-03-19 17:48:00 +00:00
Romain Pokrzywka
ff4aad0e88 export _dbus_credentials_to_string_append for the tests 2010-03-16 22:16:11 -04:00
Romain Pokrzywka
aed92380e5 Update the windows implementation of logging functions
Following commit: 04cf316600 for Unix.
2010-03-16 22:15:35 -04:00
Marcus Brinkmann
09ba65069d Fix the make dist target. 2010-03-16 23:09:48 +01:00
Marcus Brinkmann
378ef9ea37 Prepend HOMEDRIVE to HOMEPATH so cross-volume accesses work. 2010-03-16 23:09:48 +01:00
Marcus Brinkmann
378e090e71 Check return value of MoveFileEx correctly. 2010-03-16 23:09:48 +01:00
Marcus Brinkmann
a41d292607 Close process handle leak. 2010-03-16 23:09:48 +01:00
Marcus Brinkmann
7838cf15fa Use INVALID_HANDLE_VALUE, not NULL. 2010-03-16 23:09:48 +01:00
Marcus Brinkmann
5e06adfaa3 Fix possible alignment issue. 2010-03-16 23:09:48 +01:00
Colin Walters
18bcf800b6 Merge branch 'dbus-1.2' 2010-03-16 16:44:48 -04:00
Colin Walters
edecaa4abc Don't send an reply for driver messages if one isn't requested
Basically honor the no_reply flag; a binding is likely to want to
set this so it doesn't have to process extra traffic for match
rules.
2010-03-16 16:44:30 -04:00
Colin Walters
ebfa7c02fd Merge branch 'dbus-1.2'
Conflicts:
	bus/bus.c
	configure.in
2010-03-16 16:11:14 -04:00
Colin Walters
ce34415302 Make SELinux initialization failure fatal
https://bugzilla.redhat.com/show_bug.cgi?id=572769

Previously we'd just continue if AVC initialization failed, but
that didn't really work because then we'd later crash in
avc_has_perm.

Simply treat initialization failures as fatal, and hopefully we
can get data from the system log.
2010-03-16 15:57:27 -04:00
Colin Walters
f00c816c27 Add a prefix to our syslog messages
Previously we were simply logging as "dbus", and it was unclear
whether it was the system bus, or a session bus.  And if the latter,
which user?

This patch adds a prefix to the log message with the bus type
and the userid.
2010-03-16 15:57:27 -04:00
Colin Walters
e48b092849 Add _dbus_credentials_to_string_append
Convert the credentials to a string; useful for logging.
2010-03-16 15:57:27 -04:00
Colin Walters
00e031a543 Add DBUS_SYSTEM_LOG_FATAL severity
This severity is useful for when we encounter a fatal problem; we
get a log message out, then exit.
2010-03-16 15:57:24 -04:00
Colin Walters
04cf316600 Refactor _dbus_log_info, _dbus_log_security into _dbus_log_system
In preparation for a future patch which introduces a fatal logging level,
don't duplicate the API here.
2010-03-16 15:57:05 -04:00
Kimmo Hämäläinen
e28c0ece17 [dbus-spawn] Use correct sign values for variables
read() returns a signed value, whereas the byte count is unsigned.

Signed-off-by: Colin Walters <walters@verbum.org>
2010-03-16 13:55:13 -04:00
Kimmo Hämäläinen
922c6f3285 [dbus] Add missing va_end in dbus-errors.c 2010-03-16 13:50:30 -04:00
Colin Walters
322c116a53 [main] Handle OOM in reload watch
http://bugs.freedesktop.org/show_bug.cgi?id=12953

Wait for memory if we can't init the string.

Based on an original patch by Kimmo Hämäläinen <kimmo.hamalainen@nokia.com>
2010-03-16 13:11:44 -04:00
Simon McVittie
efc63e58da [doc/dbus-specification.xml] Explicitly specify lower-case hex must be used
https://bugs.freedesktop.org/show_bug.cgi?id=9486

When describing DBUS_COOKIE_SHA1, specify that lower-case hex encoding
must be used.
2010-03-16 12:40:08 -04:00
Colin Walters
8586e83a5c Support inotify on older kernels
https://bugs.freedesktop.org/show_bug.cgi?id=23957

Previously we detected glibc support at compile time and used
it unconditionally; better to try it and fall back, this way
we continue to run on older kernels when compiled for newer ones.
2010-03-16 12:21:52 -04:00
Ralf Habacker
acbc751e28 Decorated public exported functions with DBUS_EXPORT macro, reviewed by Colin Walters. 2010-03-16 09:33:39 +01:00
Marcus Brinkmann
3c657579a0 Fix double-free in error case.
Signed-off-by: Thiago Macieira <thiago@kde.org>
2010-03-15 17:08:40 +01:00
Colin Walters
f4da942cb4 [configure.in] Use AM_SILENT_RULES if available
By rough consensus, and to keep up with the cool kids.

Note to builders: you need to use V=1 to enable verbose mode.
2010-03-12 17:23:10 -05:00
Michael Meeks
ae95a0ff96 [DBusConnection] When handling a watch, return if another thread is doing I/O
http://lists.freedesktop.org/archives/dbus/2010-March/012337.html

Previously, the watch handler would block until the I/O path was available.
However, if another non-main thread was doing a synchronous call, this would
cause the main thread to block on that thread, a highly undesirable
thing because it's important for the main thread to remain responsive
for user interfaces.

Signed-off-by: Colin Walters <walters@verbum.org>
Signed-off-by: Thiago Macieira <thiago@kde.org>
2010-03-12 11:50:27 -05:00
Ralf Habacker
cf307bbc5a removed obsolate file from windbus port 2010-03-08 16:02:04 +01:00
Ralf Habacker
76919f681c fixed bus-test sha1 connection address on unix with cmake build system 2010-03-08 15:56:56 +01:00
Ralf Habacker
e469239284 fixed backtrace printing on unix with cmake build system 2010-03-08 15:55:46 +01:00
Frederic Crozat
008cd59ef7 Fix build when selinux is disabled but libaudit enabled
https://bugs.freedesktop.org/show_bug.cgi?id=26859
2010-03-03 08:19:35 -05:00
Ralf Habacker
47e37899a3 _dbus_string_toupper_ascii(): new function, reviewed by Colin Walters. 2010-02-28 21:33:41 +01:00
Ralf Habacker
b88edf2221 win32 fix: make dbus string content visible to debuggers, reviewed by Colin Walters. 2010-02-28 21:07:57 +01:00
Ralf Habacker
a06c771d2b _dbus_string_tolower_ascii(): new function, reviewed by Colin Walters. 2010-02-28 21:03:16 +01:00
Ralf Habacker
46df8b52d9 linux compile fix 2010-02-26 08:37:53 +01:00
Marcus Brinkmann
0906954d0a Generate Windows def files from def.in files. 2010-02-26 08:12:11 +01:00
Romain Pokrzywka
fdcd044555 fix potential crashes on windows with MSVC, due to badly exported variables 2010-02-25 18:20:02 +01:00
Romain Pokrzywka
0feebc3e12 --warning 2010-02-25 18:19:58 +01:00
Romain Pokrzywka
127bd1f0c3 small fixes for DBUS_USE_OUTPUT_DEBUG_STRING code 2010-02-25 18:19:54 +01:00
Ralf Habacker
1bbb46421b fixed compile break introduced in commit e1c31c7307 2010-02-25 18:12:47 +01:00
Colin Walters
e1c31c7307 Merge branch 'dbus-1.2'
Conflicts:
	bus/bus.c
	bus/selinux.c
	configure.in
2010-02-22 09:48:45 -05:00
Colin Walters
fbeb13517e [dbus-string] Sync up UNICODE_VALID with glib, add documentation
See https://bugzilla.gnome.org/show_bug.cgi?id=107427 for rationale
behind the first change.

The documentation was derived from an IRC conversation with
Behdad Esfahbod.
2010-02-19 16:34:47 -05:00
Colin Walters
235eebdb16 Finish moving file-related functions from dbus-sysdeps-unix to dbus-file-unix 2010-02-19 12:48:44 -05:00
Colin Walters
9c90fcd2dc Monitor service directories for changes
It's not expected to have to manually SIGHUP the bus after installing
a new .service file.  Since our directory monitoring is already set
up to queue a full reload which includes service activation, simply
monitor the servicedirs too.

https://bugs.freedesktop.org/show_bug.cgi?id=23846
2010-02-18 15:33:28 -05:00
Brian Cameron
8ca10fd4de Fix dummy file monitoring backend compilation
https://bugs.freedesktop.org/show_bug.cgi?id=26421
2010-02-18 10:38:42 -05:00
Colin Walters
f81e8702a6 Revert "_dbus_string_to_lower(): new function"
This reverts commit 39aa809024.
2010-02-18 10:09:20 -05:00
Ralf Habacker
39aa809024 _dbus_string_to_lower(): new function 2010-02-12 08:47:33 +01:00