fdo-mirrors/dbus
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/dbus/dbus.git synced 2026-05-05 06:28:00 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
4239 commits 20 branches 213 tags 22 MiB
Commit graph

4239 commits

This branch
This branch
All branches
Author SHA1 Message Date
Ralf Habacker
4101e0bc6c cmake: Extend underlines below dbus version print on configure summary title. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89450
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
 2015-03-24 08:38:58 +01:00
Simon McVittie
7647179096 Fix assorted compiler warnings on Windows. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89444
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
[rh: rebased because a few hunks have already been applied with commit
 92c39d1d8a]
 2015-03-24 08:27:09 +01:00
Ralf Habacker
73af0d5d5c Rename _dbus_full_duplex_pipe() to more descriptive name _dbus_socketpair(). 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89444
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-24 08:13:36 +01:00
Simon McVittie
21c41b3eb0 cmake: only set CMP0053, CMP0054 on CMake >= 3.1 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89450
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
 2015-03-24 08:10:10 +01:00
Ralf Habacker
92c39d1d8a Fix of 'warning: variable ‘..‘ set but not used [-Wunused-but-set-variable]'. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89284
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-17 16:52:51 +01:00
Ralf Habacker
40a6b6e815 Revert "Rename _dbus_full_duplex_pipe() to more descriptive name _dbus_socketpair()." 
This reverts commit ee0e15366c.
 2015-03-11 15:56:58 +01:00
Ralf Habacker
dfaf56e922 Revert "Use typedef DBusSocket for sockets fd's to avoid conversion warnings." 
This reverts commit f9192688b6.
 2015-03-11 15:42:51 +01:00
Ralf Habacker
72f246f87d cmake: opt-in to not implicitly expanding variables in if() (policy CMP0054) 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89450
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-11 15:42:39 +01:00
Ralf Habacker
f756aead90 Revert "cmake: @VAR@ substitutions in set() are deprecated, use string(CONFIGURE) instead (policy CMP0053)" 
This reverts commit 45f2e84a7d.
 2015-03-11 15:40:10 +01:00
Ralf Habacker
f9192688b6 Use typedef DBusSocket for sockets fd's to avoid conversion warnings. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89444
 2015-03-11 15:22:57 +01:00
Ralf Habacker
ee0e15366c Rename _dbus_full_duplex_pipe() to more descriptive name _dbus_socketpair(). 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89444
 2015-03-11 15:22:57 +01:00
Ralf Habacker
45f2e84a7d cmake: @VAR@ substitutions in set() are deprecated, use string(CONFIGURE) instead (policy CMP0053) 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89450
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-06 20:36:45 +01:00
Ralf Habacker
d46f7bac0d cmake: @VAR@ substitutions in set() are deprecated, use string(CONFIGURE) instead (policy CMP0053) 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89450
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-06 20:35:59 +01:00
Ralf Habacker
924bff39e6 cmake: stop using deprecated LOCATION property (policy CMP0026) 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89450
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-06 20:32:30 +01:00
Ralf Habacker
5d8f82d638 Fix cmake build system bug not generating versioned library name in case LT_REVISION is zero. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89450
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-06 20:29:36 +01:00
Ralf Habacker
ee9c52ca33 Add missing include file for cmake function check_include_files() (commit 2d2b5af) 2015-03-05 14:45:18 +01:00
Simon McVittie
58f66e6c40 dbus-print-message: conditionalize Unix FD handling on DBUS_UNIX 
We close() the fd after we have printed it, but close() isn't
standard functionality on Windows. Unix FD-passing is never going
to work on non-Unix platforms anyway.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89428
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
 2015-03-05 13:15:00 +00:00
Simon McVittie
188884dd62 dbus-monitor: use _dbus_get_real_time instead of gettimeofday 
gettimeofday is implicitly declared (i.e. not in our #include'd header
files) when cross-compiling for on Windows. Now that fd.o#83115
has been fixed, using _dbus functions is not a problem.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89428
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
 2015-03-05 13:14:37 +00:00
Simon McVittie
49d67163da Improve diagnostics when UpdateActivationEnvironment calls are rejected 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=88812
Reviewed-by: Colin Walters <walters@verbum.org>
[smcv: rebased to not require the extra code initially on that bug]
 2015-03-05 13:09:07 +00:00
Ralf Habacker
e488588501 Keep cmake generated defines for include files in sync with autotools. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=85418
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-05 14:05:59 +01:00
Ralf Habacker
cd8524ce00 Move include file checks to ConfigureChecks.cmake for cmake build system. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=85418
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-05 13:54:15 +01:00
Ralf Habacker
939b3d97ee Add check to cmake build system if config.h.cmake is in sync with autotools. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=85418
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-05 13:54:10 +01:00
Ralf Habacker
add6b4f554 Keep include file checks in sync with autotools. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=85418
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-05 13:54:04 +01:00
Ralf Habacker
4d8a27701b Add cmake macro autoheaderchecks(). 
This macro prints out any include file defined as HAVE_..._H in the config
header template and not in the related cmake configure checks file.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=85418
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-05 13:52:57 +01:00
Ralf Habacker
8696bfdf07 Fix broken cmake HAVE_SOCKLEN_T type finding check. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-05 08:14:24 +01:00
Simon McVittie
2d2b5af97d Add missing header for _dbus_sleep_milliseconds() (commit 43d2455) 2015-03-04 18:47:52 +00:00
Ralf Habacker
2c7abec29e Add test-fdpass to cmake build system. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-04 18:43:54 +00:00
Simon McVittie
0d42526efa signal_handler: avoid signed/unsigned mismatch (-Wsign-compare) 
We're ignoring the result of this write() to stderr anyway, because
if it failed... what would we do? Write to stderr? That wouldn't work
any better the second time :-)

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
 2015-03-04 18:41:15 +00:00
Ralf Habacker
08a75e07cb Enable -Wsign-compare for cmake builds. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
 2015-03-04 18:41:01 +00:00
Simon McVittie
50bd76ac5b Autotools: enable -Wsign-compare and optionally -Werror=sign-compare 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
 2015-03-04 18:40:53 +00:00
Simon McVittie
c3e345f15a fd-passing test: numbers of things are unsigned (-Wsign-compare) 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
 2015-03-04 18:40:47 +00:00
Simon McVittie
719829a41d _dbus_listen_systemd_sockets: fds are signed ints (-Wsign-compare) 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
 2015-03-04 18:40:39 +00:00
Simon McVittie
51a718c678 Use new _dbus_string_get_length_uint() to avoid another -Wsign-compare 
DBusString's length is signed for historical reasons: the right type
would have been size_t or some other unsigned type. We have a *lot*
of callers of _dbus_string_get_length(), so it is not really desirable
to do a flag-day switch; but we know that the length is always in the
range [0, INT_MAX] that is common to int and unsigned int, so we can
safely add an unsigned accessor.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
 2015-03-04 18:40:10 +00:00
Ralf Habacker
43d2455e19 Drop duplicated function tool_millisleep() and use dbus_sleep_milliseconds() instead. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89284
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-04 13:06:49 +01:00
Ralf Habacker
6588c65708 Fix warning 'conversion to ‘long unsigned int’ from ‘WriteResult’ may change the sign of the result [-Wsign-conversion]'. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89284
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-04 12:33:12 +01:00
Ralf Habacker
72549f316f Fix of 'warning: conversion to ‘dbus_bool_t‘ from ‘int‘ may change the sign of the result [-Wsign-conversion]'. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89284
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-04 12:32:53 +01:00
Ralf Habacker
0ee8a251ce Fix of 'warning: unused variable ‘result‘ [-Wunused-variable]'. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89284
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-04 12:32:53 +01:00
Ralf Habacker
50369c1219 Fix warning: conversion to 'DWORD' from 'int' may change the sign of the result [-Wsign-conversion]. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89284
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-04 12:32:53 +01:00
Ralf Habacker
d0fe556af1 Trivial -Wsign-compare fixes. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-04 12:18:42 +01:00
Simon McVittie
073aa59f8c belatedly bump version for 1.9.15 2015-03-04 10:38:36 +00:00
Peter McCurdy
c701117672 Make all time values signed longs instead of a mix of signed and unsigned, to avoid compiler complaints. 
check_timeout() tries to use some unsigned long variables to
perform some intermediate calculations, then has to cast
back to signed long. As it happens, there's no real chance
of overflowing a signed long (it'll only happen if the current
time is within 49.7 days of rolling over, at which point you're
already pretty doomed), so we can make the calculations a bit
simpler, and also avoid the mixed-signedness arithmetic we'd
otherwise need to do.

Bug: https://bugs.freedesktop.org/attachment.cgi?id=18494
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
 2015-03-04 09:56:40 +01:00
Ralf Habacker
dca6591fa2 Keep cmake defines GLIB_VERSION_... in sync with autotools. 
This patch adds autotools related cmake macros autoinit() and autodefine().

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89284
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-03 16:37:32 +01:00
Simon McVittie
38e64d7571 prepare 1.9.14 2015-03-02 14:48:25 +00:00
Ralf Habacker
c803f0fbe1 Fix warning: 'the comparison will always evaluate as 'false' for the address of '....' will never be NULL [-Waddress]' 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89284
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-03-02 09:40:22 +01:00
Dimitri John Ledkov
57971f69ef Make include_dir non-existing directory, to not be an error. 
Empty include directories were already not treated as failures.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89280
Signed-off-by: Dimitri John Ledkov <dimitri.j.ledkov@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
 2015-02-25 15:59:24 +00:00
Simon McVittie
18c01b05b8 NEWS 2015-02-24 17:02:22 +00:00
Simon McVittie
6439ab73b3 monitor test: don't block in main context if we already have messages 
Functions like become_monitor() sometimes iterate the main context,
which could leave us with unprocessed messages in f->monitored.
We need to drain that queue of unprocessed messages (setting flags
accordingly, which might meet the loop's exit condition or cause
a break) before we are willing to block in the main context again.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89222
Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
 2015-02-24 17:00:26 +00:00
Simon McVittie
909762fd08 test_init: convert SIGALRM into SIGABRT so we leave a core dump on timeout 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89222
Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
 2015-02-24 14:38:50 +00:00
Simon McVittie
c4279c1f37 NEWS 2015-02-24 13:43:17 +00:00
Ralf Habacker
267ec3b8ad dbus-monitor: Keep term 'dest' in --monitor output in sync with related watch expression. 
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=88896
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
[smcv: rebase onto differently indented version of previous commit]
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
 2015-02-24 13:30:23 +00:00