fdo-mirrors/cairo
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/cairo/cairo.git synced 2026-01-07 00:50:19 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

test: Free the memory, not the pointer to the memory

Browse source 
In read_file(), we see:

    *data = malloc (*len);
    ...
    if (fread(*data, *len, 1, fp) != 1) {
      free(data);
      ...

The free call needs to be free(*data), to match the malloc call.

Matthias Clasen found this via Coverity and proposed the fix.

Signed-off-by: Bryce Harrington <bryce@osg.samsung.com>
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=91381
This commit is contained in:
Bryce Harrington 2015-07-30 16:45:15 -07:00
parent 0dd5d84bae
commit c04bd43083
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
test/pdf-mime-data.c
View file

@ -82,7 +82,7 @@ read_file (const cairo_test_context_t *ctx,
}
if (fread(*data, *len, 1, fp) != 1) {
free (data);
free (*data);
fclose(fp);
cairo_test_log (ctx, "Could not read data from file %s\n", file);
return CAIRO_TEST_FAILURE;