From c04bd4308382db00347016e666f38fcfe8ee1f08 Mon Sep 17 00:00:00 2001 From: Bryce Harrington Date: Thu, 30 Jul 2015 16:45:15 -0700 Subject: [PATCH] test: Free the memory, not the pointer to the memory In read_file(), we see: *data = malloc (*len); ... if (fread(*data, *len, 1, fp) != 1) { free(data); ... The free call needs to be free(*data), to match the malloc call. Matthias Clasen found this via Coverity and proposed the fix. Signed-off-by: Bryce Harrington Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=91381 --- test/pdf-mime-data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/pdf-mime-data.c b/test/pdf-mime-data.c index fd5af1f7f..b49a1d18d 100644 --- a/test/pdf-mime-data.c +++ b/test/pdf-mime-data.c @@ -82,7 +82,7 @@ read_file (const cairo_test_context_t *ctx, } if (fread(*data, *len, 1, fp) != 1) { - free (data); + free (*data); fclose(fp); cairo_test_log (ctx, "Could not read data from file %s\n", file); return CAIRO_TEST_FAILURE;