fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-24 02:00:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/clients/cli
History
Thomas Haller 09c94bc24f
cli: fix accessing argv with zero elements in nmc_process_connection_properties() 
Without this, `nmcli device modify "$DEVICE"` leads to a crash. At least
since commit c5d45848dd ('cli: mark argv argument for command line
parsing as const'), when this happens.

That is, because it passes a NULL strv array with argc being set to
zero. nmc_process_connection_properties() is not supposed to access
the array, if there are no elements there.

Fixes: c5d45848dd ('cli: mark argv argument for command line parsing as const')

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/492
2020-07-13 17:15:56 +02:00
..
agent.c cli: remove redundant return value from NMCCommand funcs 2020-04-10 10:44:37 +02:00
common.c cli: remove redundant return value from NMCCommand funcs 2020-04-10 10:44:37 +02:00
common.h cli: mark argv argument for command line parsing as const 2020-04-10 10:27:27 +02:00
connections.c cli: fix accessing argv with zero elements in nmc_process_connection_properties() 2020-07-13 17:15:56 +02:00
connections.h cli: show external connection in different color 2020-06-10 19:45:46 +02:00
devices.c cli: suppress "(unknown)" output in terse mode for device properties HWADDR and DRIVER 2020-07-03 11:40:11 +02:00
devices.h cli: show external connection in different color 2020-06-10 19:45:46 +02:00
general.c cli: show differnt text for state of externally connected devices 2020-06-10 19:45:47 +02:00
generate-docs-nm-settings-nmcli.c docs: show aliases for settings in man nm-settings-nmcli 2020-06-12 14:01:26 +02:00
meson.build docs: generate nm-settings-docs-nmcli.xml based on nmcli meta data 2020-06-11 10:53:50 +02:00
nmcli-completion cli: make nmcli do its own command completion 2017-02-13 16:32:15 +01:00
nmcli.c all: fix minor typos 2020-07-07 11:33:46 +02:00
nmcli.h cli: remove redundant return value from NMCCommand funcs 2020-04-10 10:44:37 +02:00
polkit-agent.c cli/polkit: rename NM_POLKIT_LISTENER_SIGNAL_REQUEST signal to "request-sync" 2020-04-10 10:44:52 +02:00
polkit-agent.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
settings.c all: fix typo in man pages 2020-07-03 10:48:04 +02:00
settings.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
utils.c cli: let _print_fill() hide option if NM_META_ACCESSOR_GET_OUT_FLAGS_HIDE is set 2020-04-16 10:52:45 +02:00
utils.h cli: add nmc_meta_generic_get_str_i18n_null() helper 2020-07-03 11:37:45 +02:00