fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-04-22 14:00:53 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

cli/polkit: rename NM_POLKIT_LISTENER_SIGNAL_REQUEST signal to "request-sync"

Browse source 
The response is blocking, which generally is rather ugly. Let's not fix
that now, but at least rename the signal so that it clearly points this
out.
This commit is contained in:
Thomas Haller 2020-04-06 12:06:45 +02:00
parent 7d91208218
commit 0dbb9c279e
3 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
clients/cli/polkit-agent.c
View file

@ -66,7 +66,7 @@ nmc_polkit_agent_init (NmCli* nmc, gboolean for_session, GError **error)
}
g_signal_connect (listener,
NM_POLKIT_LISTENER_SIGNAL_REQUEST,
NM_POLKIT_LISTENER_SIGNAL_REQUEST_SYNC,
G_CALLBACK (polkit_read_passwd),
nmc);
g_signal_connect (listener,

10
clients/common/nm-polkit-listener.c
View file

@ -51,7 +51,7 @@
enum {
REGISTERED,
REQUEST,
REQUEST_SYNC,
ERROR,
LAST_SIGNAL
};
@ -498,9 +498,9 @@ io_watch_have_data (int fd,
unescaped = g_strcompress (request->in_buffer->str);
if (NM_STR_HAS_PREFIX (unescaped, "PAM_PROMPT_ECHO")) {
/* emit signal and wait for response */
/* FIXME(cli-async): emit signal and wait for response (blocking) */
g_signal_emit (request->listener,
signals[REQUEST],
signals[REQUEST_SYNC],
0,
request->action_id,
request->message,
@ -911,8 +911,8 @@ nm_polkit_listener_class_init (NMPolkitListenerClass *klass)
_PROPERTY_ENUMS_LAST,
obj_properties);
signals[REQUEST] =
g_signal_new (NM_POLKIT_LISTENER_SIGNAL_REQUEST,
signals[REQUEST_SYNC] =
g_signal_new (NM_POLKIT_LISTENER_SIGNAL_REQUEST_SYNC,
NM_TYPE_POLKIT_LISTENER,
G_SIGNAL_RUN_LAST,
0,

2
clients/common/nm-polkit-listener.h
View file

@ -7,7 +7,7 @@
#define __NM_POLKIT_LISTENER_H__
#define NM_POLKIT_LISTENER_SIGNAL_REGISTERED "registered"
#define NM_POLKIT_LISTENER_SIGNAL_REQUEST "secret-request"
#define NM_POLKIT_LISTENER_SIGNAL_REQUEST_SYNC "request-sync"
#define NM_POLKIT_LISTENER_SIGNAL_AUTH_SUCCESS "auth-success"
#define NM_POLKIT_LISTENER_SIGNAL_AUTH_FAILURE "auth-failure"
#define NM_POLKIT_LISTENER_SIGNAL_ERROR "error"