fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-05 22:48:01 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

config: call va_end() in unexpected code path too

Browse source 
CID 99747 (#1 of 1): Missing varargs init or cleanup (VARARGS)
13.  missing_va_end: va_end was not called for ap.
This commit is contained in:
Lubomir Rintel 2016-04-28 17:36:09 +02:00
parent a06487a6ae
commit dc9bba9e51
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/nm-config.c
View file

@ -1837,20 +1837,18 @@ _nm_config_state_set (NMConfig *self,
switch (property_type) { switch (property_type) {
case NM_CONFIG_STATE_PROPERTY_NETWORKING_ENABLED: case NM_CONFIG_STATE_PROPERTY_NETWORKING_ENABLED:
p_bool = &priv->state->p.net_enabled; p_bool = &priv->state->p.net_enabled;
goto handle_p_bool; break;
case NM_CONFIG_STATE_PROPERTY_WIFI_ENABLED: case NM_CONFIG_STATE_PROPERTY_WIFI_ENABLED:
p_bool = &priv->state->p.wifi_enabled; p_bool = &priv->state->p.wifi_enabled;
goto handle_p_bool; break;
case NM_CONFIG_STATE_PROPERTY_WWAN_ENABLED: case NM_CONFIG_STATE_PROPERTY_WWAN_ENABLED:
p_bool = &priv->state->p.wwan_enabled; p_bool = &priv->state->p.wwan_enabled;
goto handle_p_bool;
default:
break; break;
default:
va_end (ap);
g_return_if_reached ();
} }
g_return_if_reached ();
handle_p_bool:
v_bool = va_arg (ap, gboolean); v_bool = va_arg (ap, gboolean);
if (*p_bool == v_bool) if (*p_bool == v_bool)
continue; continue;