From dc9bba9e518a34b00a4be94725ce34b63bde989c Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Thu, 28 Apr 2016 17:36:09 +0200 Subject: [PATCH] config: call va_end() in unexpected code path too CID 99747 (#1 of 1): Missing varargs init or cleanup (VARARGS) 13. missing_va_end: va_end was not called for ap. --- src/nm-config.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/nm-config.c b/src/nm-config.c index f7c47497a7..1088b91148 100644 --- a/src/nm-config.c +++ b/src/nm-config.c @@ -1837,20 +1837,18 @@ _nm_config_state_set (NMConfig *self, switch (property_type) { case NM_CONFIG_STATE_PROPERTY_NETWORKING_ENABLED: p_bool = &priv->state->p.net_enabled; - goto handle_p_bool; + break; case NM_CONFIG_STATE_PROPERTY_WIFI_ENABLED: p_bool = &priv->state->p.wifi_enabled; - goto handle_p_bool; + break; case NM_CONFIG_STATE_PROPERTY_WWAN_ENABLED: p_bool = &priv->state->p.wwan_enabled; - goto handle_p_bool; - default: break; + default: + va_end (ap); + g_return_if_reached (); } - g_return_if_reached (); - -handle_p_bool: v_bool = va_arg (ap, gboolean); if (*p_bool == v_bool) continue;