fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-19 13:50:44 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert "core: make Device emit StateChanged a bit later"

Browse source 
Thomas thinks this is a bad idea and probably is right:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1000#note_1122853

This reverts commit c75b7dd893.
This commit is contained in:
Lubomir Rintel 2021-11-01 11:24:14 +01:00
parent 28770eb394
commit c6dc7a7ea7
1 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/core/devices/nm-device.c
View file

@ -16705,15 +16705,6 @@ _set_state_full(NMDevice *self, NMDeviceState state, NMDeviceStateReason reason,
_notify(self, PROP_STATE);
_notify(self, PROP_STATE_REASON);
g_signal_emit(self,
signals[STATE_CHANGED],
0,
(guint) state,
(guint) old_state,
(guint) reason);
/* Only tell the clients of the change once we dealt with the state
* change internally. That is, policy finished the DNS update and such. */
nm_dbus_object_emit_signal(NM_DBUS_OBJECT(self),
&interface_info_device,
&signal_info_state_changed,
@ -16721,6 +16712,12 @@ _set_state_full(NMDevice *self, NMDeviceState state, NMDeviceStateReason reason,
(guint32) state,
(guint32) old_state,
(guint32) reason);
g_signal_emit(self,
signals[STATE_CHANGED],
0,
(guint) state,
(guint) old_state,
(guint) reason);
/* Post-process the event after internal notification */