fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-26 22:50:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

core: make Device emit StateChanged a bit later

Browse source 
We need to make sure StateChanged goes on the D-Bus only after the
policy is done dealing with the state change internally.

This is done so that we can be sure the DNS changes are committed at the
time "nmcli c up" returns.

https://bugzilla.redhat.com/show_bug.cgi?id=2006677
This commit is contained in:
Lubomir Rintel 2021-10-18 12:43:17 +02:00
parent 29380a0b09
commit c75b7dd893
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/core/devices/nm-device.c
View file

@ -16705,6 +16705,15 @@ _set_state_full(NMDevice *self, NMDeviceState state, NMDeviceStateReason reason,
_notify(self, PROP_STATE);
_notify(self, PROP_STATE_REASON);
g_signal_emit(self,
signals[STATE_CHANGED],
0,
(guint) state,
(guint) old_state,
(guint) reason);
/* Only tell the clients of the change once we dealt with the state
* change internally. That is, policy finished the DNS update and such. */
nm_dbus_object_emit_signal(NM_DBUS_OBJECT(self),
&interface_info_device,
&signal_info_state_changed,
@ -16712,12 +16721,6 @@ _set_state_full(NMDevice *self, NMDeviceState state, NMDeviceStateReason reason,
(guint32) state,
(guint32) old_state,
(guint32) reason);
g_signal_emit(self,
signals[STATE_CHANGED],
0,
(guint) state,
(guint) old_state,
(guint) reason);
/* Post-process the event after internal notification */