fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-16 13:30:19 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

libnm: mark missing "FwMark" for NMDeviceIPTunnel as ignored

Browse source 
This was forgotten to implement. But we cannot just forget about it.
Libnm emits a warning about unknown properties, exactly to catch such
bugs. Properties that are not implemented, must be marked to be ignored.

Next, support for this property will be added. But that introduces new
API, which cannot be backported. Hence, first fix the problem by marking
the property as ignored. This is a backportable change.

  $ LIBNM_CLIENT_DEBUG="warning" G_DEBUG=fatal-warnings nmcli
  (process:270215): nm-WARNING **: 15:22:56.125: libnm-dbus: <warn > nmclient[8094a8c217aae461]: get-managed-objects: [/org/freedesktop/NetworkManager/Devices/5]: ignore unknown property org.freedesktop.NetworkManager.Device.IPTunnel.FwMark
  Trace/breakpoint trap (core dumped)

Fixes: 351c562491 ('devices: support VTI tunnels')
This commit is contained in:
Thomas Haller 2023-11-17 15:12:57 +01:00
parent 0f626a5ede
commit b47c94666c
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/libnm-client-impl/nm-device-ip-tunnel.c
View file

@ -357,6 +357,7 @@ const NMLDBusMetaIface _nml_dbus_meta_iface_nm_device_iptunnel = NML_DBUS_META_I
PROP_FLOW_LABEL,
NMDeviceIPTunnel,
_priv.flow_label),
NML_DBUS_META_PROPERTY_INIT_IGNORE("FwMark", "u"),
NML_DBUS_META_PROPERTY_INIT_S("InputKey",
PROP_INPUT_KEY,
NMDeviceIPTunnel,