From b47c94666c9fbdaef5b5a410f87ae85e62fc1136 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 17 Nov 2023 15:12:57 +0100 Subject: [PATCH] libnm: mark missing "FwMark" for NMDeviceIPTunnel as ignored This was forgotten to implement. But we cannot just forget about it. Libnm emits a warning about unknown properties, exactly to catch such bugs. Properties that are not implemented, must be marked to be ignored. Next, support for this property will be added. But that introduces new API, which cannot be backported. Hence, first fix the problem by marking the property as ignored. This is a backportable change. $ LIBNM_CLIENT_DEBUG="warning" G_DEBUG=fatal-warnings nmcli (process:270215): nm-WARNING **: 15:22:56.125: libnm-dbus: nmclient[8094a8c217aae461]: get-managed-objects: [/org/freedesktop/NetworkManager/Devices/5]: ignore unknown property org.freedesktop.NetworkManager.Device.IPTunnel.FwMark Trace/breakpoint trap (core dumped) Fixes: 351c56249157 ('devices: support VTI tunnels') --- src/libnm-client-impl/nm-device-ip-tunnel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libnm-client-impl/nm-device-ip-tunnel.c b/src/libnm-client-impl/nm-device-ip-tunnel.c index c34ad84b05..19fe6fd3df 100644 --- a/src/libnm-client-impl/nm-device-ip-tunnel.c +++ b/src/libnm-client-impl/nm-device-ip-tunnel.c @@ -357,6 +357,7 @@ const NMLDBusMetaIface _nml_dbus_meta_iface_nm_device_iptunnel = NML_DBUS_META_I PROP_FLOW_LABEL, NMDeviceIPTunnel, _priv.flow_label), + NML_DBUS_META_PROPERTY_INIT_IGNORE("FwMark", "u"), NML_DBUS_META_PROPERTY_INIT_S("InputKey", PROP_INPUT_KEY, NMDeviceIPTunnel,