fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-06-07 12:19:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

dhcp/trivial: add fixme comment about stopping clients

Browse source
This commit is contained in:
Thomas Haller 2019-05-29 14:47:57 +02:00
parent 58eee5896d
commit 9a7929bdb1
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/dhcp/nm-dhcp-manager.c
View file

@ -208,6 +208,12 @@ client_start (NMDhcpManager *self,
/* Kill any old client instance */
client = get_client_for_ifindex (self, addr_family, ifindex);
if (client) {
/* FIXME: we cannot just call synchronously "stop()" and forget about the client.
* We need to wait for the client to be fully stopped because most/all clients
* cannot quit right away.
*
* FIXME(shutdown): also fix this during shutdown, to wait for all DHCP clients
* to be fully stopped. */
remove_client (self, client);
nm_dhcp_client_stop (client, FALSE);
g_object_unref (client);