From 9a7929bdb154c5d884638bbd39cac82688e21a8b Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 29 May 2019 14:47:57 +0200 Subject: [PATCH] dhcp/trivial: add fixme comment about stopping clients --- src/dhcp/nm-dhcp-manager.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/dhcp/nm-dhcp-manager.c b/src/dhcp/nm-dhcp-manager.c index fe843a2ce4..42a5eca971 100644 --- a/src/dhcp/nm-dhcp-manager.c +++ b/src/dhcp/nm-dhcp-manager.c @@ -208,6 +208,12 @@ client_start (NMDhcpManager *self, /* Kill any old client instance */ client = get_client_for_ifindex (self, addr_family, ifindex); if (client) { + /* FIXME: we cannot just call synchronously "stop()" and forget about the client. + * We need to wait for the client to be fully stopped because most/all clients + * cannot quit right away. + * + * FIXME(shutdown): also fix this during shutdown, to wait for all DHCP clients + * to be fully stopped. */ remove_client (self, client); nm_dhcp_client_stop (client, FALSE); g_object_unref (client);