fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-05 15:00:25 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

core: avoid coverity warning in device factory's _add_factory()

Browse source 
2. NetworkManager-1.9.2/src/devices/nm-device-factory.c:312:
returned_pointer: Assigning value from "g_slist_append(list,
g_object_ref(factory))" to "list" here, but that stored value is
overwritten before it can be used.
This commit is contained in:
Thomas Haller 2017-10-30 14:43:41 +01:00
parent 66e1fdb7ec
commit 98afc76184
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/devices/nm-device-factory.c
View file

@ -309,7 +309,7 @@ _add_factory (NMDeviceFactory *factory,
for (i = 0; setting_types && setting_types[i]; i++) {
list = g_hash_table_lookup (factories_by_setting, (char *) setting_types[i]);
if (list)
list = g_slist_append (list, g_object_ref (factory));
g_slist_append (list, g_object_ref (factory));
else {
list = g_slist_append (list, g_object_ref (factory));
g_hash_table_insert (factories_by_setting, (char *) setting_types[i], list);