From 98afc76184502d8e19092d631efb07091be81af2 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Mon, 30 Oct 2017 14:43:41 +0100 Subject: [PATCH] core: avoid coverity warning in device factory's _add_factory() 2. NetworkManager-1.9.2/src/devices/nm-device-factory.c:312: returned_pointer: Assigning value from "g_slist_append(list, g_object_ref(factory))" to "list" here, but that stored value is overwritten before it can be used. --- src/devices/nm-device-factory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/devices/nm-device-factory.c b/src/devices/nm-device-factory.c index 0d1c601f1e..d3d1f251fb 100644 --- a/src/devices/nm-device-factory.c +++ b/src/devices/nm-device-factory.c @@ -309,7 +309,7 @@ _add_factory (NMDeviceFactory *factory, for (i = 0; setting_types && setting_types[i]; i++) { list = g_hash_table_lookup (factories_by_setting, (char *) setting_types[i]); if (list) - list = g_slist_append (list, g_object_ref (factory)); + g_slist_append (list, g_object_ref (factory)); else { list = g_slist_append (list, g_object_ref (factory)); g_hash_table_insert (factories_by_setting, (char *) setting_types[i], list);