fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-29 17:20:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

device: use correct field "l3cfg_" to clear in dispose()

Browse source 
The fields "l3cfg" and "l3cfg_" are union aliases. One of them is const,
the other is not. The idea is that all places that modify the field need
to use the special name "l3cfg_", and grepping for that will lead you to
all the relevant places.

This mistake happened, because g_clear_object() casts constness away.

Fixes: 58287cbcc0 ('core: rework IP configuration in NetworkManager using layer 3 configuration')
This commit is contained in:
Thomas Haller 2022-12-06 14:57:50 +01:00
parent 37e130232d
commit 8cb739031d
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/core/devices/nm-device.c
View file

@ -17891,7 +17891,7 @@ dispose(GObject *object)
priv->sriov.next = NULL;
}
g_clear_object(&priv->l3cfg);
g_clear_object(&priv->l3cfg_);
g_clear_object(&priv->l3ipdata_4.ip_config);
g_clear_object(&priv->l3ipdata_6.ip_config);