fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-07 11:20:23 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

dhcp: fix crash in "nm-dhcp-helper" passing NULL to g_dbus_connection_flush_sync()

Browse source 
"connection" variable might be NULL, which fails an assertion in
g_dbus_connection_flush_sync(). Consequently, "error_flush" is also
NULL which leads to a crash of "nm-dhcp-helper".

Reported-by: Jules Maselbas <jmaselbas@zdiv.net>

Fixes: 240ec7f891 ('dhcp: implement ACD (address collision detection) for DHCPv4')
This commit is contained in:
Thomas Haller 2022-12-05 21:57:17 +01:00
parent 8fd73f2be2
commit 37e130232d
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/core/dhcp/nm-dhcp-helper.c
View file

@ -252,7 +252,7 @@ do_notify:
success = FALSE;
out:
if (!g_dbus_connection_flush_sync(connection, NULL, &error_flush)) {
if (connection && !g_dbus_connection_flush_sync(connection, NULL, &error_flush)) {
_LOGE("could not flush D-Bus connection: %s", error_flush->message);
/* if we considered this a success so far, don't fail because of this. */
}