fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-07 07:18:03 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

settings/ifupdown: fix block_name typo in initialize()

Browse source 
In commit f0938948bc a typo creeped in and
"block->name" got replaced by "block_name". Variable block_name is used
for a different purpose and not initialized at this point.
As a result g_str_has_prefix crashes with a segfault.

Spotted by Bernhard Übelacker <bernhardu@mailbox.org>

Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911621
Fixes: f0938948bc

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/31
(cherry picked from commit 8179b23d76)
This commit is contained in:
Michael Biebl 2018-10-23 19:52:52 +02:00 • committed by Lubomir Rintel
parent 576f0877f3
commit 0ffb390bf3
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/settings/plugins/ifupdown/nms-ifupdown-plugin.c
View file

@ -171,7 +171,7 @@ initialize (NMSettingsPlugin *plugin)
if (nm_streq (block->type, "iface")) { if (nm_streq (block->type, "iface")) {
/* Bridge configuration */ /* Bridge configuration */
if (g_str_has_prefix (block_name, "br")) { if (g_str_has_prefix (block->name, "br")) {
/* Try to find bridge ports */ /* Try to find bridge ports */
const char *ports = ifparser_getkey (block, "bridge-ports"); const char *ports = ifparser_getkey (block, "bridge-ports");