From 0ffb390bf3390aafd08ba5df5d0b4eb96e93327e Mon Sep 17 00:00:00 2001 From: Michael Biebl Date: Tue, 23 Oct 2018 19:52:52 +0200 Subject: [PATCH] settings/ifupdown: fix block_name typo in initialize() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In commit f0938948bc506f2bddda2d574b0890cb4b67b4c4 a typo creeped in and "block->name" got replaced by "block_name". Variable block_name is used for a different purpose and not initialized at this point. As a result g_str_has_prefix crashes with a segfault. Spotted by Bernhard Übelacker Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911621 Fixes: f0938948bc506f2bddda2d574b0890cb4b67b4c4 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/31 (cherry picked from commit 8179b23d7617ef913bc2170ab71a36a11280b745) --- src/settings/plugins/ifupdown/nms-ifupdown-plugin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/settings/plugins/ifupdown/nms-ifupdown-plugin.c b/src/settings/plugins/ifupdown/nms-ifupdown-plugin.c index 88c651b859..b66eedc70a 100644 --- a/src/settings/plugins/ifupdown/nms-ifupdown-plugin.c +++ b/src/settings/plugins/ifupdown/nms-ifupdown-plugin.c @@ -171,7 +171,7 @@ initialize (NMSettingsPlugin *plugin) if (nm_streq (block->type, "iface")) { /* Bridge configuration */ - if (g_str_has_prefix (block_name, "br")) { + if (g_str_has_prefix (block->name, "br")) { /* Try to find bridge ports */ const char *ports = ifparser_getkey (block, "bridge-ports");