fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-20 07:00:05 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

device: fix signal emission on port detach/release

Browse source 
The "notify::controller" signal must be emitted on the port, not on
the controller.

Fixes: 1f05526ed7 ('core: drop NMDevice master and introduce controller')
This commit is contained in:
Beniamino Galvani 2025-07-18 09:02:52 +02:00
parent 394f6281ea
commit 012f1cbfac
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/core/devices/nm-device.c
View file

@ -9029,7 +9029,7 @@ nm_device_port_notify_attach_as_port(NMDevice *self, gboolean success)
priv->is_attached = TRUE; priv->is_attached = TRUE;
_notify(priv->controller, PROP_CONTROLLER); _notify(self, PROP_CONTROLLER);
nm_clear_pointer(&NM_DEVICE_GET_PRIVATE(priv->controller)->ports_variant, nm_clear_pointer(&NM_DEVICE_GET_PRIVATE(priv->controller)->ports_variant,
g_variant_unref); g_variant_unref);
@ -9108,7 +9108,7 @@ nm_device_port_notify_release(NMDevice *self,
priv->is_attached = FALSE; priv->is_attached = FALSE;
_notify(priv->controller, PROP_CONTROLLER); _notify(self, PROP_CONTROLLER);
nm_clear_pointer(&NM_DEVICE_GET_PRIVATE(priv->controller)->ports_variant, g_variant_unref); nm_clear_pointer(&NM_DEVICE_GET_PRIVATE(priv->controller)->ports_variant, g_variant_unref);
nm_gobject_notify_together(priv->controller, PROP_PORTS, PROP_SLAVES); nm_gobject_notify_together(priv->controller, PROP_PORTS, PROP_SLAVES);