From 012f1cbfacf1bac9fd9888b68ee48adbae9e7085 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Fri, 18 Jul 2025 09:02:52 +0200 Subject: [PATCH] device: fix signal emission on port detach/release The "notify::controller" signal must be emitted on the port, not on the controller. Fixes: 1f05526ed77e ('core: drop NMDevice master and introduce controller') --- src/core/devices/nm-device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/devices/nm-device.c b/src/core/devices/nm-device.c index fd0eb7dba6..198e75ec70 100644 --- a/src/core/devices/nm-device.c +++ b/src/core/devices/nm-device.c @@ -9029,7 +9029,7 @@ nm_device_port_notify_attach_as_port(NMDevice *self, gboolean success) priv->is_attached = TRUE; - _notify(priv->controller, PROP_CONTROLLER); + _notify(self, PROP_CONTROLLER); nm_clear_pointer(&NM_DEVICE_GET_PRIVATE(priv->controller)->ports_variant, g_variant_unref); @@ -9108,7 +9108,7 @@ nm_device_port_notify_release(NMDevice *self, priv->is_attached = FALSE; - _notify(priv->controller, PROP_CONTROLLER); + _notify(self, PROP_CONTROLLER); nm_clear_pointer(&NM_DEVICE_GET_PRIVATE(priv->controller)->ports_variant, g_variant_unref); nm_gobject_notify_together(priv->controller, PROP_PORTS, PROP_SLAVES);