From f770bfadc115f145867a13a64dab4188dc4f8d57 Mon Sep 17 00:00:00 2001 From: lukasx999 <116069013+lukasx999@users.noreply.github.com> Date: Mon, 11 Aug 2025 21:27:38 +0200 Subject: [PATCH] smart pointer factories should not be static --- include/hyprutils/memory/SharedPtr.hpp | 2 +- include/hyprutils/memory/UniquePtr.hpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/hyprutils/memory/SharedPtr.hpp b/include/hyprutils/memory/SharedPtr.hpp index a523def..3c97691 100644 --- a/include/hyprutils/memory/SharedPtr.hpp +++ b/include/hyprutils/memory/SharedPtr.hpp @@ -184,7 +184,7 @@ namespace Hyprutils { }; template - static CSharedPointer makeShared(Args&&... args) { + [[nodiscard]] inline CSharedPointer makeShared(Args&&... args) { return CSharedPointer(new U(std::forward(args)...)); } diff --git a/include/hyprutils/memory/UniquePtr.hpp b/include/hyprutils/memory/UniquePtr.hpp index 676b945..47dae19 100644 --- a/include/hyprutils/memory/UniquePtr.hpp +++ b/include/hyprutils/memory/UniquePtr.hpp @@ -136,7 +136,7 @@ namespace Hyprutils { }; template - static CUniquePointer makeUnique(Args&&... args) { + [[nodiscard]] inline CUniquePointer makeUnique(Args&&... args) { return CUniquePointer(new U(std::forward(args)...)); } } @@ -147,4 +147,4 @@ struct std::hash> { std::size_t operator()(const Hyprutils::Memory::CUniquePointer& p) const noexcept { return std::hash{}(p.impl_); } -}; \ No newline at end of file +};