From e54adc4394b6ea2dc3cb71bab8ca9e6507ee6ca0 Mon Sep 17 00:00:00 2001 From: lukasx999 <116069013+lukasx999@users.noreply.github.com> Date: Mon, 11 Aug 2025 21:46:24 +0200 Subject: [PATCH] defaulting default ctors is more readable and considered best practice instead of providing a default implementation --- include/hyprutils/memory/Atomic.hpp | 8 ++------ include/hyprutils/memory/SharedPtr.hpp | 4 +--- include/hyprutils/memory/UniquePtr.hpp | 4 +--- include/hyprutils/memory/WeakPtr.hpp | 4 +--- 4 files changed, 5 insertions(+), 15 deletions(-) diff --git a/include/hyprutils/memory/Atomic.hpp b/include/hyprutils/memory/Atomic.hpp index c4998a7..77505a9 100644 --- a/include/hyprutils/memory/Atomic.hpp +++ b/include/hyprutils/memory/Atomic.hpp @@ -83,9 +83,7 @@ namespace Hyprutils::Memory { std::swap(m_ptr, ref.m_ptr); } - CAtomicSharedPointer() noexcept { - ; // empty - } + CAtomicSharedPointer() noexcept = default; CAtomicSharedPointer(std::nullptr_t) noexcept { ; // empty @@ -262,9 +260,7 @@ namespace Hyprutils::Memory { m_ptr = ref.m_ptr; } - CAtomicWeakPointer() noexcept { - ; // empty - } + CAtomicWeakPointer() noexcept = default; CAtomicWeakPointer(std::nullptr_t) noexcept { ; // empty diff --git a/include/hyprutils/memory/SharedPtr.hpp b/include/hyprutils/memory/SharedPtr.hpp index 3c97691..3b1b3ca 100644 --- a/include/hyprutils/memory/SharedPtr.hpp +++ b/include/hyprutils/memory/SharedPtr.hpp @@ -61,9 +61,7 @@ namespace Hyprutils { } /* creates an empty shared pointer with no implementation */ - CSharedPointer() noexcept { - ; // empty - } + CSharedPointer() noexcept = default; /* creates an empty shared pointer with no implementation */ CSharedPointer(std::nullptr_t) noexcept { diff --git a/include/hyprutils/memory/UniquePtr.hpp b/include/hyprutils/memory/UniquePtr.hpp index 47dae19..e5b80ec 100644 --- a/include/hyprutils/memory/UniquePtr.hpp +++ b/include/hyprutils/memory/UniquePtr.hpp @@ -42,9 +42,7 @@ namespace Hyprutils { } /* creates an empty unique pointer with no implementation */ - CUniquePointer() noexcept { - ; // empty - } + CUniquePointer() noexcept = default; /* creates an empty unique pointer with no implementation */ CUniquePointer(std::nullptr_t) noexcept { diff --git a/include/hyprutils/memory/WeakPtr.hpp b/include/hyprutils/memory/WeakPtr.hpp index 8b734d0..35d3ac6 100644 --- a/include/hyprutils/memory/WeakPtr.hpp +++ b/include/hyprutils/memory/WeakPtr.hpp @@ -102,9 +102,7 @@ namespace Hyprutils { } /* create an empty weak ptr */ - CWeakPointer() { - ; - } + CWeakPointer() noexcept = default; ~CWeakPointer() { decrementWeak();