hyprwm/Hyprland
1
0
Fork 0
mirror of https://github.com/hyprwm/Hyprland synced 2026-05-07 16:58:07 +02:00
Code Issues Projects Releases Packages Wiki Activity

xwayland: prevent potential buffer overflow in socket path handling (#13797)

Browse source
This commit is contained in:
Visal Vijay 2026-03-22 05:09:58 +05:30 • committed by Vaxry
parent a61633a365
commit aaea8547d6
Signed by: vaxry
GPG key ID: 665806380871D640
1 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/xwayland/Server.cpp
View file

@ -138,24 +138,29 @@ static bool openSockets(std::array<CFileDescriptor, 2>& sockets, int display) {
#ifdef __linux__
if (*CREATEABSTRACTSOCKET) {
// cursed...
// but is kept as an option for better compatibility
addr.sun_path[0] = 0;
addr.sun_path[0] = '\0';
path = getSocketPath(display, true);
strncpy(addr.sun_path + 1, path.c_str(), path.length() + 1);
strncpy(addr.sun_path + 1, path.c_str(), sizeof(addr.sun_path) - 2);
} else {
path = getSocketPath(display, false);
strncpy(addr.sun_path, path.c_str(), path.length() + 1);
strncpy(addr.sun_path, path.c_str(), sizeof(addr.sun_path) - 1);
addr.sun_path[sizeof(addr.sun_path) - 1] = '\0';
}
#else
if (*CREATEABSTRACTSOCKET) {
Log::logger->log(Log::WARN, "The abstract XWayland Unix domain socket might be used only on Linux systems. A regular one'll be created instead.");
}
path = getSocketPath(display, false);
strncpy(addr.sun_path, path.c_str(), path.length() + 1);
strncpy(addr.sun_path, path.c_str(), sizeof(addr.sun_path) - 1);
addr.sun_path[sizeof(addr.sun_path) - 1] = '\0';
#endif
sockets[0] = CFileDescriptor{createSocket(&addr, path.length())};
if (!sockets[0].isValid())
return false;