From 9cdd5e8337b1fc3c16faed492b9344832adb20d8 Mon Sep 17 00:00:00 2001 From: Vaxry <43317083+vaxerski@users.noreply.github.com> Date: Sat, 7 Mar 2026 18:47:17 +0000 Subject: [PATCH] layout/groupTarget: fix crash on null space assignment (#13614) nullchecks my life --- src/layout/LayoutManager.cpp | 3 ++- src/layout/target/WindowGroupTarget.cpp | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/layout/LayoutManager.cpp b/src/layout/LayoutManager.cpp index 4a93809cd..3f28085f2 100644 --- a/src/layout/LayoutManager.cpp +++ b/src/layout/LayoutManager.cpp @@ -95,7 +95,8 @@ void CLayoutManager::endDragTarget() { } void CLayoutManager::fullscreenRequestForTarget(SP target, eFullscreenMode currentEffectiveMode, eFullscreenMode effectiveMode) { - target->space()->setFullscreen(target, effectiveMode); + if (target->space()) + target->space()->setFullscreen(target, effectiveMode); } void CLayoutManager::switchTargets(SP a, SP b, bool preserveFocus) { diff --git a/src/layout/target/WindowGroupTarget.cpp b/src/layout/target/WindowGroupTarget.cpp index ae883751e..3b1dc91e9 100644 --- a/src/layout/target/WindowGroupTarget.cpp +++ b/src/layout/target/WindowGroupTarget.cpp @@ -38,7 +38,8 @@ void CWindowGroupTarget::updatePos() { void CWindowGroupTarget::assignToSpace(const SP& space, std::optional focalPoint) { ITarget::assignToSpace(space, focalPoint); - m_group->updateWorkspace(space->workspace()); + if (space) + m_group->updateWorkspace(space->workspace()); } bool CWindowGroupTarget::floating() {