From 75f6435f70dee8f8b685a02c52db7ba16f5db39c Mon Sep 17 00:00:00 2001
From: Tom Englund <tomenglund26@gmail.com>
Date: Thu, 11 Dec 2025 19:54:43 +0100
Subject: [PATCH] window: only damage floating on clamped size change (#12633)

currently it damage the entire window if its floating and not x11 nor
fullscreen meaning damage isnt working at all for floating. im tracing
this back to a364df4 where the logic changed from damaging window only
if size was being forced to now unconditonally doing it.

change clampWindowSize to return as a bool if size changed and only
damage window if it got clamped.
---
 src/desktop/view/Window.cpp | 17 +++++++++++------
 src/desktop/view/Window.hpp |  2 +-
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/src/desktop/view/Window.cpp b/src/desktop/view/Window.cpp
index f83235403..b01dcabc0 100644
--- a/src/desktop/view/Window.cpp
+++ b/src/desktop/view/Window.cpp
@@ -1197,14 +1197,19 @@ int CWindow::surfacesCount() {
     return no;
 }
 
-void CWindow::clampWindowSize(const std::optional<Vector2D> minSize, const std::optional<Vector2D> maxSize) {
+bool CWindow::clampWindowSize(const std::optional<Vector2D> minSize, const std::optional<Vector2D> maxSize) {
     const Vector2D REALSIZE = m_realSize->goal();
     const Vector2D MAX      = isFullscreen() ? Vector2D{INFINITY, INFINITY} : maxSize.value_or(Vector2D{INFINITY, INFINITY});
     const Vector2D NEWSIZE  = REALSIZE.clamp(minSize.value_or(Vector2D{MIN_WINDOW_SIZE, MIN_WINDOW_SIZE}), MAX);
-    const Vector2D DELTA    = REALSIZE - NEWSIZE;
+    const bool     changed  = !(NEWSIZE == REALSIZE);
 
-    *m_realPosition = m_realPosition->goal() + DELTA / 2.0;
-    *m_realSize     = NEWSIZE;
+    if (changed) {
+        const Vector2D DELTA = REALSIZE - NEWSIZE;
+        *m_realPosition      = m_realPosition->goal() + DELTA / 2.0;
+        *m_realSize          = NEWSIZE;
+    }
+
+    return changed;
 }
 
 bool CWindow::isFullscreen() {
@@ -2554,8 +2559,8 @@ void CWindow::commitWindow() {
         const auto MINSIZE = m_xdgSurface->m_toplevel->layoutMinSize();
         const auto MAXSIZE = m_xdgSurface->m_toplevel->layoutMaxSize();
 
-        clampWindowSize(MINSIZE, MAXSIZE > Vector2D{1, 1} ? std::optional<Vector2D>{MAXSIZE} : std::nullopt);
-        g_pHyprRenderer->damageWindow(m_self.lock());
+        if (clampWindowSize(MINSIZE, MAXSIZE > Vector2D{1, 1} ? std::optional<Vector2D>{MAXSIZE} : std::nullopt))
+            g_pHyprRenderer->damageWindow(m_self.lock());
     }
 
     if (!m_workspace->m_visible)
diff --git a/src/desktop/view/Window.hpp b/src/desktop/view/Window.hpp
index e1a42eda5..d5c86aac2 100644
--- a/src/desktop/view/Window.hpp
+++ b/src/desktop/view/Window.hpp
@@ -286,7 +286,7 @@ namespace Desktop::View {
         bool                       onSpecialWorkspace();
         void                       activate(bool force = false);
         int                        surfacesCount();
-        void                       clampWindowSize(const std::optional<Vector2D> minSize, const std::optional<Vector2D> maxSize);
+        bool                       clampWindowSize(const std::optional<Vector2D> minSize, const std::optional<Vector2D> maxSize);
         bool                       isFullscreen();
         bool                       isEffectiveInternalFSMode(const eFullscreenMode) const;
         int                        getRealBorderSize() const;