desktop/windowRules: fix disabling binary window rules with override (#12635)

This commit is contained in:
Lichie 2025-12-15 14:19:13 -08:00 committed by GitHub
parent 6b491e4d6b
commit 6e09eb2e6c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 19 deletions

View file

@ -41,12 +41,11 @@ namespace Desktop::Rule {
std::string monitor, workspace, group;
std::optional<bool> floating;
bool fullscreen = false;
bool maximize = false;
bool pseudo = false;
bool pin = false;
bool noInitialFocus = false;
std::optional<bool> fullscreen;
std::optional<bool> maximize;
std::optional<bool> pseudo;
std::optional<bool> pin;
std::optional<bool> noInitialFocus;
std::optional<int> fullscreenStateClient;
std::optional<int> fullscreenStateInternal;

View file

@ -2047,14 +2047,10 @@ void CWindow::mapWindow() {
requestedFSMonitor = MONITOR_INVALID;
}
if (m_ruleApplicator->static_.floating.has_value())
m_isFloating = m_ruleApplicator->static_.floating.value();
if (m_ruleApplicator->static_.pseudo)
m_isPseudotiled = true;
if (m_ruleApplicator->static_.noInitialFocus)
m_noInitialFocus = true;
m_isFloating = m_ruleApplicator->static_.floating.value_or(m_isFloating);
m_isPseudotiled = m_ruleApplicator->static_.pseudo.value_or(m_isPseudotiled);
m_noInitialFocus = m_ruleApplicator->static_.noInitialFocus.value_or(m_noInitialFocus);
m_pinned = m_ruleApplicator->static_.pin.value_or(m_pinned);
if (m_ruleApplicator->static_.fullscreenStateClient || m_ruleApplicator->static_.fullscreenStateInternal) {
requestedFSState = Desktop::View::SFullscreenState{
@ -2080,13 +2076,10 @@ void CWindow::mapWindow() {
}
}
if (m_ruleApplicator->static_.pin)
m_pinned = true;
if (m_ruleApplicator->static_.fullscreen)
if (m_ruleApplicator->static_.fullscreen.value_or(false))
requestedInternalFSMode = FSMODE_FULLSCREEN;
if (m_ruleApplicator->static_.maximize)
if (m_ruleApplicator->static_.maximize.value_or(false))
requestedInternalFSMode = FSMODE_MAXIMIZED;
if (!m_ruleApplicator->static_.group.empty()) {