fdo-mirrors/xserver
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/xorg/xserver.git synced 2026-01-06 19:00:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
read-only mirror of https://gitlab.freedesktop.org/xorg/xserver
18664 commits 90 branches 540 tags 92 MiB
C 96.4%
Roff 1.1%
Objective-C 1%
Meson 0.8%
Shell 0.2%
Other 0.3%
Find a file
Olivier Fourdan ffd4d2a268 xkb: Always use MAP_LENGTH keymap size 
Generating the modifier modmap, the helper function generate_modkeymap()
would check the entire range up to the MAP_LENGTH.

However, the given keymap might have less keycodes than MAP_LENGTH, in
which case we would go beyond the size of the modmap, as reported by
ASAN:

==ERROR: AddressSanitizer: heap-buffer-overflow
READ of size 1 at 0x5110001c225b thread T0
    #0 0x5e7369393873 in generate_modkeymap ../dix/inpututils.c:309
    #1 0x5e736930dcce in ProcGetModifierMapping ../dix/devices.c:1794
    #2 0x5e7369336489 in Dispatch ../dix/dispatch.c:550
    #3 0x5e736934407d in dix_main ../dix/main.c:275
    #5 0x7e46d47b2ecb in __libc_start_main
    #6 0x5e73691be324 in _start (xserver/build/hw/xwayland/Xwayland)

Address is located 0 bytes after 219-byte region
allocated by thread T0 here:
    #0 0x7e46d4cfc542 in realloc
    #1 0x5e73695aa90e in _XkbCopyClientMap ../xkb/xkbUtils.c:1142
    #2 0x5e73695aa90e in XkbCopyKeymap ../xkb/xkbUtils.c:1966
    #3 0x5e73695b1b2f in XkbDeviceApplyKeymap ../xkb/xkbUtils.c:2023
    #4 0x5e73691c6c18 in keyboard_handle_keymap ../hw/xwayland/xwayland-input.c:1194

As MAP_LENGTH is used in various code paths where the max keycode might
not be easily available, best is to always use MAP_LENGTH to allocate the
keymaps so that the code never run past the buffer size.

If the max key code is smaller than the MAP_LENGTH limit, fill-in the gap
with zeros.

That also simplifies the code slightly as we do not constantly need to
reallocate the keymap to adjust to the max key code size.

Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1780
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
(cherry picked from commit 92bcebfd7e)

Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1766>
2025-02-04 09:21:04 +01:00
.gitlab-ci CI: update libdecor from 0.1.0 to 0.1.1 2024-09-24 11:33:02 +02:00
composite Drop Xorg DDX 2024-04-12 10:40:05 +02:00
damageext Remove autotools support 2021-10-27 13:15:40 +03:00
dbe Drop Xorg DDX 2024-04-12 10:40:05 +02:00
dix dix: limit checks to MAX_VALUATORS when generating Xi events 2025-02-04 09:18:51 +01:00
doc dix: dixutils: make workQueue pointer dix-private 2024-02-23 23:06:38 +00:00
dri3 Drop Xorg DDX 2024-04-12 10:40:05 +02:00
fb Drop Xorg DDX 2024-04-12 10:40:05 +02:00
glamor glamor: xv: Rewrite UYVY shader to match NV12/I420 CSC 2024-08-06 10:00:59 +02:00
glx Drop Xorg DDX 2024-04-12 10:40:05 +02:00
hw xwayland: Do not keep the cursor's pixmap around 2025-02-04 09:20:54 +01:00
include dix-config.h: add HAVE_SOCKLEN_T definition 2025-02-04 09:19:33 +01:00
man Drop Xorg DDX 2024-04-12 10:40:05 +02:00
mi Drop Xorg DDX 2024-04-12 10:40:05 +02:00
miext Drop miext/shadow directory 2024-04-12 10:40:05 +02:00
os os: NextDPMSTimeout: mark intentional fallthroughs in switch 2025-02-04 09:17:35 +01:00
present build: Move epoll dependency check 2024-09-24 10:49:33 +02:00
randr Drop Xorg DDX 2024-04-12 10:40:05 +02:00
record dix: unexport eventconvert.h functions 2024-03-11 12:26:44 +01:00
render render: avoid NULL pointer dereference if PictureFindVisual returns NULL 2025-02-04 09:18:34 +01:00
test Drop Xephyr / kdrive DDX 2024-04-12 10:40:05 +02:00
Xext Drop Xorg DDX 2024-04-12 10:40:05 +02:00
xfixes Move sizeof to second argument in calloc calls 2024-08-06 10:00:59 +02:00
Xi Xi: avoid NULL pointer dereference if GetXTestDevice returns NULL 2025-02-04 09:18:26 +01:00
xkb xkb: Always use MAP_LENGTH keymap size 2025-02-04 09:21:04 +01:00
.appveyor.yml Drop Xephyr / kdrive DDX 2024-04-12 10:40:05 +02:00
.dir-locals.el .dir-locals.el: Add missing final newline 2019-10-01 17:05:28 +00:00
.gitignore Clean up the .gitignore file 2024-01-12 00:50:24 +00:00
.gitlab-ci.yml CI: update libdecor from 0.1.0 to 0.1.1 2024-09-24 11:33:02 +02:00
.mailmap Add a .mailmap file to canonicalize author names and emails 2023-03-15 18:10:51 +00:00
COPYING modesetting: Merge modesetting's COPYING into the xserver's. 2014-09-15 12:46:02 -07:00
meson.build Bump version to 24.1.4 2024-10-29 16:27:04 +01:00
meson_options.txt meson: Build Xwayland unconditionally 2024-04-12 10:40:05 +02:00
README.md Fix spelling/wording issues 2020-07-05 13:07:33 -07:00
xserver.ent.in doc: relocate xserver.ent in the package root directory 2011-05-14 11:22:26 -07:00

README.md

X Server

The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.

Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.

For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server

All questions regarding this software should be directed at the Xorg mailing list:

https://lists.freedesktop.org/mailman/listinfo/xorg

The primary development code repository can be found at:

https://gitlab.freedesktop.org/xorg/xserver

For patch submission instructions, see:

https://www.x.org/wiki/Development/Documentation/SubmittingPatches

As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc:

https://www.freedesktop.org/wiki/CodeOfConduct