Find a file
Alan Coopersmith f340f082b8 dix: limit checks to MAX_VALUATORS when generating Xi events
Previously, it was looping through sizeof(ev->valuators.mask) * 8
valuators, where valuators.mask is defined as an array of
(MAX_VALUATORS + 7) / 8 entries.  Since MAX_VALUATORS is defined as 36,
this made it actually loop through 40 entries.  The last 4 bits in this
array should never be set, so we should never access memory outside the
bounds of the arrays defined to be exactly MAX_VALUATORS in length, but
we can make the static analyzer happier and not waste time checking bits
that should never be set.

Found by Oracle Parfait 13.3 static analyzer:

   Read outside array bounds [read-outside-array-bounds]:
      In array dereference of ev->valuators.data[i] with index i
      Array size is 36 elements (of 8 bytes each), index >= 0 and index <= 39
        at line 741 of dix/eventconvert.c in function 'eventToDeviceEvent'.

   Read outside array bounds [read-outside-array-bounds]:
      In array dereference of ev->valuators.data[i] with index i
      Array size is 36 elements (of 8 bytes each), index >= 0 and index <= 39
        at line 808 of dix/eventconvert.c in function 'eventToRawEvent'.

   Read outside array bounds [read-outside-array-bounds]:
      In array dereference of ev->valuators.data_raw[i] with index i
      Array size is 36 elements (of 8 bytes each), index >= 0 and index <= 39
        at line 809 of dix/eventconvert.c in function 'eventToRawEvent'.

Fixes: b2ba77bac ("dix: add EventToXI2 and GetXI2Type.")
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
(cherry picked from commit b65eea43dd)

Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1766>
2025-02-04 09:18:51 +01:00
.gitlab-ci CI: update libdecor from 0.1.0 to 0.1.1 2024-09-24 11:33:02 +02:00
composite Drop Xorg DDX 2024-04-12 10:40:05 +02:00
damageext Remove autotools support 2021-10-27 13:15:40 +03:00
dbe Drop Xorg DDX 2024-04-12 10:40:05 +02:00
dix dix: limit checks to MAX_VALUATORS when generating Xi events 2025-02-04 09:18:51 +01:00
doc dix: dixutils: make workQueue pointer dix-private 2024-02-23 23:06:38 +00:00
dri3 Drop Xorg DDX 2024-04-12 10:40:05 +02:00
fb Drop Xorg DDX 2024-04-12 10:40:05 +02:00
glamor glamor: xv: Rewrite UYVY shader to match NV12/I420 CSC 2024-08-06 10:00:59 +02:00
glx Drop Xorg DDX 2024-04-12 10:40:05 +02:00
hw xwayland/glamor/gbm: Don't close fence_fd after xwl_glamor_wait_fence 2025-02-04 09:17:46 +01:00
include Drop config directory 2024-04-12 10:40:05 +02:00
man Drop Xorg DDX 2024-04-12 10:40:05 +02:00
mi Drop Xorg DDX 2024-04-12 10:40:05 +02:00
miext Drop miext/shadow directory 2024-04-12 10:40:05 +02:00
os os: NextDPMSTimeout: mark intentional fallthroughs in switch 2025-02-04 09:17:35 +01:00
present build: Move epoll dependency check 2024-09-24 10:49:33 +02:00
randr Drop Xorg DDX 2024-04-12 10:40:05 +02:00
record dix: unexport eventconvert.h functions 2024-03-11 12:26:44 +01:00
render render: avoid NULL pointer dereference if PictureFindVisual returns NULL 2025-02-04 09:18:34 +01:00
test Drop Xephyr / kdrive DDX 2024-04-12 10:40:05 +02:00
Xext Drop Xorg DDX 2024-04-12 10:40:05 +02:00
xfixes Move sizeof to second argument in calloc calls 2024-08-06 10:00:59 +02:00
Xi Xi: avoid NULL pointer dereference if GetXTestDevice returns NULL 2025-02-04 09:18:26 +01:00
xkb xkb: Fix buffer overflow in _XkbSetCompatMap() 2024-10-29 16:26:59 +01:00
.appveyor.yml Drop Xephyr / kdrive DDX 2024-04-12 10:40:05 +02:00
.dir-locals.el .dir-locals.el: Add missing final newline 2019-10-01 17:05:28 +00:00
.gitignore Clean up the .gitignore file 2024-01-12 00:50:24 +00:00
.gitlab-ci.yml CI: update libdecor from 0.1.0 to 0.1.1 2024-09-24 11:33:02 +02:00
.mailmap Add a .mailmap file to canonicalize author names and emails 2023-03-15 18:10:51 +00:00
COPYING modesetting: Merge modesetting's COPYING into the xserver's. 2014-09-15 12:46:02 -07:00
meson.build Bump version to 24.1.4 2024-10-29 16:27:04 +01:00
meson_options.txt meson: Build Xwayland unconditionally 2024-04-12 10:40:05 +02:00
README.md Fix spelling/wording issues 2020-07-05 13:07:33 -07:00
xserver.ent.in doc: relocate xserver.ent in the package root directory 2011-05-14 11:22:26 -07:00

X Server

The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.

Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.

For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server

All questions regarding this software should be directed at the Xorg mailing list:

https://lists.freedesktop.org/mailman/listinfo/xorg

The primary development code repository can be found at:

https://gitlab.freedesktop.org/xorg/xserver

For patch submission instructions, see:

https://www.x.org/wiki/Development/Documentation/SubmittingPatches

As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc:

https://www.freedesktop.org/wiki/CodeOfConduct