Find a file
Peter Hutterer ee5377d94e dix: fix DeviceStateNotify event calculation
The previous code only made sense if one considers buttons and keys to
be mutually exclusive on a device. That is not necessarily true, causing
a number of issues.

This function allocates and fills in the number of xEvents we need to
send the device state down the wire.  This is split across multiple
32-byte devices including one deviceStateNotify event and optional
deviceKeyStateNotify, deviceButtonStateNotify and (possibly multiple)
deviceValuator events.

The previous behavior would instead compose a sequence
of [state, buttonstate, state, keystate, valuator...]. This is not
protocol correct, and on top of that made the code extremely convoluted.

Fix this by streamlining: add both button and key into the deviceStateNotify
and then append the key state and button state, followed by the
valuators. Finally, the deviceValuator events contain up to 6 valuators
per event but we only ever sent through 3 at a time. Let's double that
troughput.

CVE-2024-0229, ZDI-CAN-22678

This vulnerability was discovered by:
Jan-Niklas Sohn working with Trend Micro Zero Day Initiative

(cherry picked from commit 219c54b8a3)
2024-01-16 10:05:46 +01:00
.gitlab-ci meson: Change project name to xwayland 2023-07-18 12:52:07 +00:00
composite Drop Xorg DDX 2023-07-18 12:52:07 +00:00
damageext Remove autotools support 2021-10-27 13:15:40 +03:00
dbe Drop Xorg DDX 2023-07-18 12:52:07 +00:00
dix dix: fix DeviceStateNotify event calculation 2024-01-16 10:05:46 +01:00
doc Remove autotools support 2021-10-27 13:15:40 +03:00
dri3 Drop Xorg DDX 2023-07-18 12:52:07 +00:00
fb Drop Xorg DDX 2023-07-18 12:52:07 +00:00
glamor glamor: Fall back for mixed depth 24/32 in glamor_set_alu 2024-01-11 11:20:05 +01:00
glx Drop Xorg DDX 2023-07-18 12:52:07 +00:00
hw glamor: Make glamor_set_alu take a DrawablePtr 2024-01-11 11:19:58 +01:00
include dix: initialize the XTest sendEventsProc for all devices 2024-01-11 10:03:23 +01:00
m4 Add ax_pthread.m4 to m4/ 2016-05-29 19:20:51 -07:00
man Disallow byte-swapped clients by default 2023-01-06 11:59:37 +10:00
mi mi: Fix up alpha channel if needed in miPaintWindow 2023-07-27 16:50:36 +02:00
miext Drop miext/shadow directory 2023-07-18 12:52:07 +00:00
os os: Use KERN_PROC_ARGS to determine client command on DragonFly and FreeBSD 2024-01-11 09:59:35 +01:00
present Drop Xorg DDX 2023-07-18 12:52:07 +00:00
randr randr: avoid integer truncation in length check of ProcRRChange*Property 2023-12-13 11:42:25 +10:00
record record: Fix out of bounds access in SwapCreateRegister() 2021-12-14 15:00:00 +02:00
render Drop Xorg DDX 2023-07-18 12:52:07 +00:00
test Drop Xephyr / kdrive DDX 2023-07-18 12:52:07 +00:00
Xext dix: initialize the XTest sendEventsProc for all devices 2024-01-11 10:03:23 +01:00
xfixes Remove "All rights reserved" from Oracle copyright notices 2023-02-25 09:40:41 -08:00
Xi dix: allocate enough space for logical button maps 2024-01-16 10:05:40 +01:00
xkb ddxLoad: Check XDG_RUNTIME_DIR before fallback to /tmp/ 2023-04-06 00:48:12 +00:00
.appveyor.yml Drop Xephyr / kdrive DDX 2023-07-18 12:52:07 +00:00
.dir-locals.el .dir-locals.el: Add missing final newline 2019-10-01 17:05:28 +00:00
.gitignore .gitignore: Add new autotools file 'test-driver' 2014-04-21 13:41:42 -07:00
.gitlab-ci.yml Drop Xwin DDX and x86 MinGW-w64 cross build 2023-07-18 12:52:07 +00:00
.mailmap Add a .mailmap file to canonicalize author names and emails 2023-03-15 18:10:51 +00:00
COPYING modesetting: Merge modesetting's COPYING into the xserver's. 2014-09-15 12:46:02 -07:00
meson.build Bump version to 23.2.3 2023-12-13 11:52:59 +10:00
meson_options.txt build: Allow for custom server config directory 2023-11-29 11:32:05 +01:00
README.md Fix spelling/wording issues 2020-07-05 13:07:33 -07:00
xserver.ent.in doc: relocate xserver.ent in the package root directory 2011-05-14 11:22:26 -07:00

X Server

The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.

Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.

For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server

All questions regarding this software should be directed at the Xorg mailing list:

https://lists.freedesktop.org/mailman/listinfo/xorg

The primary development code repository can be found at:

https://gitlab.freedesktop.org/xorg/xserver

For patch submission instructions, see:

https://www.x.org/wiki/Development/Documentation/SubmittingPatches

As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc:

https://www.freedesktop.org/wiki/CodeOfConduct