xserver/hw
George Staplin eb6f884d4f XQuartz: GL: Add a branch for a NULL DrawablePtr.
This may fix a bug where a NULL structure pointer was accessed resulting in:
KERN_PROTECTION_FAILURE at 0x0000000000000004

I studied the structures in use, and I believe it was the pDraw->id that resulted in
this fault in attach().

The layout of the _Drawable structure is 4 chars, and then the id, so the offset
seems correct for such a bug.

Also make it return an error for now, and ErrorF() to help us figure out where it's
going wrong elsewhere to cause a NULL DrawablePtr.

I also made various formatting changes, because the formatting was inconsistent.
Next time I will probably do the formatting in a separate commit, but hindsight is
20/20.

I will apply a fix to the 1.5 branch after this, in a similar manner.
2008-11-22 10:38:06 -07:00
..
dmx dmx: link in XSERVER_LIBS. 2008-05-16 17:20:08 +03:00
kdrive Revert "kdrive: don't post motion event if there was no motion. #16179" 2008-07-29 13:17:27 +09:30
vfb Darwin: Use __APPLE__ instead of __DARWIN__ 2007-12-07 18:53:31 -08:00
xfree86 Merge commit 'origin/server-1.4-branch' into xorg-server-1.4-apple 2008-08-05 12:44:56 -07:00
xgl Death to RCS tags. 2007-06-29 14:06:52 -04:00
xnest Darwin: Use __APPLE__ instead of __DARWIN__ 2007-12-07 18:53:31 -08:00
xprint Merge branch 'server-1.4-branch' into xorg-server-1.4-apple 2008-05-17 14:55:57 -07:00
xquartz XQuartz: GL: Add a branch for a NULL DrawablePtr. 2008-11-22 10:38:06 -07:00
xwin Death to RCS tags. 2007-06-29 14:06:52 -04:00
Makefile.am Darwin: Use __APPLE__ instead of __DARWIN__ 2007-12-07 18:53:31 -08:00