Find a file
Olivier Fourdan affb27caa2 os: Fix NULL pointer dereference
RemoveHost() can be called from DisableLocalHost() with a NULL client,
but doesn't actually check whether the given client pointer is valid on
error and assigns the error value unconditionally, leading to a possible
NULL pointer dereference and a crash of the Xserver.

To avoid the issue, simply check whether the client pointer is not NULL
prior to assign the errorValue.

Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1752
See-also: https://bugzilla.redhat.com/2313799
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1701>
(cherry picked from commit 57a446c0f9)
2026-01-25 10:39:57 -08:00
.gitlab-ci CI: update meson from 0.56.2 (bullseye) to 1.0.0 (bullseye-backports) 2026-01-25 10:39:57 -08:00
composite treewide: fix indentions got broke by recent commit 2026-01-25 10:39:56 -08:00
config treewide: replace xnfcalloc() calls by XNFcallocarray() 2026-01-25 10:39:55 -08:00
damageext prevent name clash on Windows w/ RT_* defines 2026-01-19 12:48:30 -08:00
dbe treewide: fix indentions got broke by recent commit 2026-01-25 10:39:56 -08:00
dix dix: FindBestPixel: fix implicit fallthrough warning 2026-01-25 10:39:57 -08:00
doc doc: drop removed functions from the Xserver spec 2026-01-25 10:39:56 -08:00
dri3 treewide: replace xnfalloc() calls to XNFalloc() 2026-01-25 10:39:55 -08:00
exa Move sizeof to second argument in calloc calls 2026-01-25 10:39:55 -08:00
fb fb: Fix 1bpp Xservers on "whitePixel=0, blackPixel=1" VRAMs 2024-01-03 19:43:16 +00:00
glamor include: dixfontstr.h: drop silent dependency on libxfont2 2026-01-25 10:39:56 -08:00
glx treewide: replace xnfstrdup() calls by XNFstrdup() 2026-01-25 10:39:55 -08:00
hw xfree86: os-support: bsd: fix missing include of xf86_OSproc.h 2026-01-25 10:39:57 -08:00
include os: unexport CloseDownConnection() 2026-01-25 10:39:56 -08:00
man Xserver.man: Note that -byteswappedclients is the default in this release 2026-01-19 12:32:23 -08:00
mi mi: drop obsolete mibitblt.c 2026-01-25 10:39:56 -08:00
miext os: move os_move_fd() out of public API 2026-01-19 12:32:20 -08:00
os os: Fix NULL pointer dereference 2026-01-25 10:39:57 -08:00
present build: Move epoll dependency check 2026-01-25 10:39:56 -08:00
pseudoramiX fix missing includes of <X11/Xfuncproto.h> 2026-01-25 10:39:55 -08:00
randr prevent name clash on Windows w/ RT_* defines 2026-01-19 12:48:30 -08:00
record record: clean up Sun/Solaris specific hack 2026-01-25 10:39:53 -08:00
render xace: typesafe hook function for XACE_RESOURCE_ACCESS 2026-01-25 10:39:54 -08:00
test test: dix_input_valuator_masks(): use fixed array instead of VLA 2026-01-25 10:39:56 -08:00
Xext Xext: xf86bigfont: code styling cleanups 2026-01-25 10:39:56 -08:00
xfixes Move sizeof to second argument in calloc calls 2026-01-25 10:39:55 -08:00
Xi Xi: when removing a master search for a disabled paired device 2026-01-25 10:39:56 -08:00
xkb treewide: replace xnfstrdup() calls by XNFstrdup() 2026-01-25 10:39:55 -08:00
.appveyor.yml appveyor: Add libxcvt build dep 2021-11-04 13:03:25 +00:00
.dir-locals.el .dir-locals.el: Add missing final newline 2019-10-01 17:05:28 +00:00
.gitignore Clean up the .gitignore file 2024-01-12 00:50:24 +00:00
.gitlab-ci.yml ci: reduce nolibdecor build to xwayland only 2026-01-25 10:39:57 -08:00
.mailmap Add a .mailmap file to canonicalize author names and emails 2023-03-15 18:10:51 +00:00
.travis.yml travis: Add OSX meson build to matrix 2019-05-02 15:42:58 +00:00
COPYING modesetting: Merge modesetting's COPYING into the xserver's. 2014-09-15 12:46:02 -07:00
meson.build meson: list required version of xproto headers in xorg-server.pc 2026-01-25 10:39:57 -08:00
meson_options.txt os: drop SUN-DES-1 authentication 2026-01-25 10:39:53 -08:00
README.md Fix spelling/wording issues 2020-07-05 13:07:33 -07:00
xorg-server.m4 xorg-server.m4: just all cflags instead of just sdkdir 2018-09-20 20:12:24 +01:00
xorg-server.pc.in xfree86: link modules against Xorg symbols on Cygwin 2012-04-05 21:57:07 -05:00
xserver.ent.in doc: relocate xserver.ent in the package root directory 2011-05-14 11:22:26 -07:00

X Server

The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.

Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.

For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server

All questions regarding this software should be directed at the Xorg mailing list:

https://lists.freedesktop.org/mailman/listinfo/xorg

The primary development code repository can be found at:

https://gitlab.freedesktop.org/xorg/xserver

For patch submission instructions, see:

https://www.x.org/wiki/Development/Documentation/SubmittingPatches

As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc:

https://www.freedesktop.org/wiki/CodeOfConduct