xserver/dix
Peter Hutterer 93d1441487 cursor: fix AllocARGBCursor leak/double-free for psrcbits/pmaskbits/argb
AllocARGBCursor took ownership of the psrcbits/pmaskbits/argb arguments.
But if the initial calloc failed none of them were freed, without the
caller knowing about it. Depending on the code path, those arguments
would thus either leak or be double-freed.

Fix it by always freeing those on error and updating the callers
accordingly.

Assisted-by: Claude:claude-opus-4-6
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2214>
2026-05-17 23:57:42 +00:00
..
.gitignore Fix spelling/wording issues 2020-07-05 13:07:33 -07:00
atom.c atom: make FreeAtom static 2015-07-08 16:41:29 -04:00
BuiltInAtoms Strip trailing whitespace from source files 2026-01-25 10:40:02 -08:00
closestr.h dix: move closestr.h into dix directory 2026-01-19 12:48:30 -08:00
colormap.c dix: FindBestPixel: fix implicit fallthrough warning 2026-01-25 10:39:57 -08:00
cursor.c cursor: fix AllocARGBCursor leak/double-free for psrcbits/pmaskbits/argb 2026-05-17 23:57:42 +00:00
devices.c dix: handle various allocation failures 2026-04-28 02:37:43 +00:00
dispatch.c cursor: fix AllocARGBCursor leak/double-free for psrcbits/pmaskbits/argb 2026-05-17 23:57:42 +00:00
dispatch.h Drop trailing whitespaces 2014-11-12 10:25:00 +10:00
dixfonts.c dix: Silent static analyzer warning 2026-04-29 13:08:12 +00:00
dixutils.c treewide: replace xnfrealloc() calls to XNFrealloc() 2026-01-25 10:39:55 -08:00
enterleave.c dix: handle allocation failure in DeviceFocusEvent() 2026-01-25 10:40:03 -08:00
enterleave.h mi: reset the PointerWindows reference on screen switch 2023-10-25 00:37:47 +00:00
eventconvert.c dix: limit checks to MAX_VALUATORS when generating Xi events 2026-01-25 10:39:58 -08:00
events.c dix: handle various allocation failures 2026-04-28 02:37:43 +00:00
extension.c Move sizeof to second argument in calloc calls 2026-01-25 10:39:55 -08:00
gc.c dix: set errorValue correctly when XID lookup fails in ChangeGCXIDs() 2026-01-25 10:40:03 -08:00
gestures.c dix: avoid null dereference if wOtherInputMasks() returns NULL 2026-01-25 10:40:03 -08:00
getevents.c dix: fix wheel emulation lockup when a negative increment is set 2023-02-20 15:11:23 +10:00
globals.c include: Remove now-empty site.h 2019-10-30 16:17:04 +00:00
glyphcurs.c Let calloc handle multiplication 2015-04-21 16:57:07 -07:00
grabs.c dix: CreateGrab() rename "type" parameter to "eventType" 2026-01-25 10:39:57 -08:00
initatoms.c Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
inpututils.c xace: typesafe hook function for XACE_DEVICE_ACCESS 2026-01-25 10:39:54 -08:00
main.c dix: keep a ref to the rootCursor 2026-01-25 10:40:00 -08:00
meson.build meson: add install_tags to files meson couldnt guess on its own 2026-03-28 16:54:18 +00:00
pixmap.c Fix typos 2026-03-03 06:50:01 -03:00
privates.c Move sizeof to second argument in calloc calls 2026-01-25 10:39:55 -08:00
property.c dix: avoid memory leak in ProcListProperties() 2026-01-25 10:40:03 -08:00
protocol.txt drop remains of DMX 2026-01-19 12:32:20 -08:00
ptrveloc.c Fix typos 2026-03-03 06:50:01 -03:00
region.c replace _X_INLINE by inline in internal static functions 2024-02-05 19:26:14 +00:00
registry.c rename remaining RT_* defines to X11_RESTYPE_* 2026-01-19 12:48:30 -08:00
resource.c dix: HashResourceID: use unsigned integers for bit shifting 2026-01-25 10:39:57 -08:00
selection.c dix: Add dixSetSelectionOwner() 2026-04-27 14:24:04 +02:00
stubmain.c Allow DDX to provide a main() 2013-07-23 23:56:58 +01:00
swaprep.c dix: assert that size of buffers to swap is a multiple of the swap size 2026-01-25 10:40:03 -08:00
swapreq.c dix: drop swapping request length fields 2026-01-25 10:39:59 -08:00
tables.c dix: drop swapping request length fields 2026-01-25 10:39:59 -08:00
touch.c dix: avoid null dereference if wOtherInputMasks() returns NULL 2026-01-25 10:40:03 -08:00
window.c cursor: fix AllocARGBCursor leak/double-free for psrcbits/pmaskbits/argb 2026-05-17 23:57:42 +00:00