mirror of
https://gitlab.freedesktop.org/xorg/xserver.git
synced 2025-12-27 04:40:06 +01:00
The install rule of Xorg.wrap is currently a dependency of the
install-data target instead of the install-exec target. The build also
uses install-exec-hook to change the ownership and set the SUID bit on
the Xorg.wrap binary. The problem is that install-exec-hook is only
ordered respective to the install-exec target, the rules of install-data
may or may not have been executed.
If install-exec-hook runs before the Xorg.wrap binary is in place,
a message similar to the following will be present in the build log:
chown: cannot access '/pkgdir/usr/lib/xorg-server/Xorg.wrap': No such file or directory
make[6]: [Makefile:1151: install-exec-hook] Error 1 (ignored)
All that needs to be done is to change the name of the program variable
to contain 'exec' for the install rule to depend on the install-exec
target.
Excerpt from the Automake manual, chapter 12.2 The Two Parts of Install:
"Any variable using a user-defined directory prefix with ‘exec’ in the
name (e.g., myexecbin_PROGRAMS) is installed by install-exec. All other
user-defined prefixes are installed by install-data."
https://bugs.freedesktop.org/show_bug.cgi?id=104419
Signed-off-by: Lukáš Krejčí <lskrejci@gmail.com>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| common | ||
| ddc | ||
| dixmods | ||
| doc | ||
| dri | ||
| dri2 | ||
| drivers | ||
| exa | ||
| fbdevhw | ||
| glamor_egl | ||
| i2c | ||
| int10 | ||
| loader | ||
| man | ||
| modes | ||
| os-support | ||
| parser | ||
| ramdac | ||
| shadowfb | ||
| utils | ||
| vbe | ||
| vgahw | ||
| x86emu | ||
| xkb | ||
| .gitignore | ||
| Makefile.am | ||
| sdksyms.sh | ||
| xorg-wrapper.c | ||
| Xorg.sh.in | ||
| xorgconf.cpp | ||