Find a file
Michel Dänzer 39e141eac0 xwayland: Replace window pixmap as needed for drawing operation
We must not modify the contents of a client pixmap.

If there's an available window buffer, we re-use that for the window
pixmap. Otherwise we just allocate a new one.

This also avoids Present client hangs due to xwl_present_buffer_release
not getting called for the buffer release event.

v2:
* Use xwl_pixmap_get_buffer_release_cb instead of keeping track of the
  flip pixmap in xwl_window.
* Dispose of xwl_window_buffer in xwl_window_swap_pixmap called from
  damage_report.
v3:
* Use xwl_window->surface_pixmap in damage_report.
v4:
* Don't re-use client pixmaps as window buffers.
* Clear xwl_window_buffer->pixmap before calling
  xwl_window_buffer_maybe_dispose in xwl_window_swap_pixmap, to prevent
  it from clearing the buffer release callback.
v5:
* Keep using xwl_window_buffers_get_pixmap in xwl_window_attach_buffer.
* Always keep a reference to the old window pixmap in _swap_pixmap,
  drop it in damage_report.

Fixes: 6779ec5bf6 ("xwayland: Use window pixmap as a window buffer")
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1633
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1644
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1314>
(cherry picked from commit 6b290fa5d9)
2026-01-19 12:32:20 -08:00
.gitlab-ci drop remains of DMX 2026-01-19 12:32:20 -08:00
composite composite: Expose CompositeIsImplicitRedirectException 2023-07-18 09:34:39 +00:00
config Fix build on OpenBSD. 2026-01-19 12:32:17 -08:00
damageext Remove autotools support 2021-10-27 13:15:40 +03:00
dbe dbe: drop obsolete NEED_DBE_PROTOCOL 2026-01-19 12:32:19 -08:00
dix drop remains of DMX 2026-01-19 12:32:20 -08:00
doc dix: dixutils: make workQueue pointer dix-private 2026-01-19 12:32:18 -08:00
dri3 randr: move private definitons from randrstr.h to randrstr_priv.h 2026-01-19 12:32:18 -08:00
exa replace _X_INLINE by inline in internal static functions 2024-02-05 19:26:14 +00:00
fb fb: Fix 1bpp Xservers on "whitePixel=0, blackPixel=1" VRAMs 2024-01-03 19:43:16 +00:00
glamor glamor: drop duplicate _X_EXPORT from .c source 2026-01-19 12:32:19 -08:00
glx glx: move private definitions from vndserver.h to vndserver_priv.h 2026-01-19 12:32:18 -08:00
hw xwayland: Replace window pixmap as needed for drawing operation 2026-01-19 12:32:20 -08:00
include drop remains of DMX 2026-01-19 12:32:20 -08:00
m4 Add ax_pthread.m4 to m4/ 2016-05-29 19:20:51 -07:00
man Disallow byte-swapped clients by default 2023-01-06 11:59:37 +10:00
mi drop remains of DMX 2026-01-19 12:32:20 -08:00
miext miext: sync: drop duplicate _X_EXPORT from .c sources 2026-01-19 12:32:19 -08:00
os include: move xsha1.h to os/ 2026-01-19 12:32:20 -08:00
present randr: move private definitons from randrstr.h to randrstr_priv.h 2026-01-19 12:32:18 -08:00
pseudoramiX Remove autotools support 2021-10-27 13:15:40 +03:00
randr randr: drop duplicate _X_EXPORT from .c source 2026-01-19 12:32:19 -08:00
record record: Support architectures with sizeof(void*) > sizeof(long) 2023-12-17 19:30:52 +00:00
render include: move xsha1.h to os/ 2026-01-19 12:32:20 -08:00
test xkb: drop defining XKBSRV_NEED_FILE_FUNCS 2026-01-19 12:32:18 -08:00
Xext drop remains of DMX 2026-01-19 12:32:20 -08:00
xfixes Remove "All rights reserved" from Oracle copyright notices 2023-02-25 09:40:41 -08:00
Xi Xi: drop duplicate _X_EXPORT from .c source 2026-01-19 12:32:19 -08:00
xkb xkb: drop duplicate _X_EXPORT from .c source 2026-01-19 12:32:19 -08:00
.appveyor.yml appveyor: Add libxcvt build dep 2021-11-04 13:03:25 +00:00
.dir-locals.el .dir-locals.el: Add missing final newline 2019-10-01 17:05:28 +00:00
.gitignore Clean up the .gitignore file 2024-01-12 00:50:24 +00:00
.gitlab-ci.yml CI: replace the dist script with invocations of the meson-build script 2026-01-19 12:32:19 -08:00
.mailmap Add a .mailmap file to canonicalize author names and emails 2023-03-15 18:10:51 +00:00
.travis.yml travis: Add OSX meson build to matrix 2019-05-02 15:42:58 +00:00
COPYING modesetting: Merge modesetting's COPYING into the xserver's. 2014-09-15 12:46:02 -07:00
meson.build build: Xwayland with GLAMOR requires libxshmfence 2026-01-19 12:32:20 -08:00
meson_options.txt meson: add option for systemd_notify 2024-01-08 01:23:55 +00:00
README.md Fix spelling/wording issues 2020-07-05 13:07:33 -07:00
xorg-server.m4 xorg-server.m4: just all cflags instead of just sdkdir 2018-09-20 20:12:24 +01:00
xorg-server.pc.in xfree86: link modules against Xorg symbols on Cygwin 2012-04-05 21:57:07 -05:00
xserver.ent.in doc: relocate xserver.ent in the package root directory 2011-05-14 11:22:26 -07:00

X Server

The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.

Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.

For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server

All questions regarding this software should be directed at the Xorg mailing list:

https://lists.freedesktop.org/mailman/listinfo/xorg

The primary development code repository can be found at:

https://gitlab.freedesktop.org/xorg/xserver

For patch submission instructions, see:

https://www.x.org/wiki/Development/Documentation/SubmittingPatches

As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc:

https://www.freedesktop.org/wiki/CodeOfConduct