Find a file
Michel Dänzer 34934c37d6 Revert "xwayland: Call register_damage depending on ensure_surface_for_window"
There've been reports downstream of Xwayland segfaulting in the function
xwl_present_execute() because xwl_window_get_damage_region() returned an
invalid pointer:

 #10 RegionUninit at ../include/regionstr.h:165
 #11 RegionEmpty at ../include/regionstr.h:194
 #12 xwl_present_execute at ../hw/xwayland/xwayland-present.c:1138
 #13 xwl_present_pixmap at ../hw/xwayland/xwayland-present.c:1274
 #14 present_pixmap at ../present/present.c:249
 #15 proc_present_pixmap_common at ../present/present_request.c:166
 #16 proc_present_pixmap at ../present/present_request.c:186
 #17 Dispatch at ../dix/dispatch.c:550
 #18 dix_main at ../dix/main.c:277

The most likely reason for this is that window_get_damage() returned
NULL, which might happen if xwl_window_update_surface_window() didn't
call register_damage().

To avoid that issue, move the call to register_damage() back to
xwl_realize_window before calling ensure_surface_for_window().

This reverts commit 07f6032627.

See-also: https://bugzilla.redhat.com/2329815
See-also: https://bugzilla.redhat.com/2428249
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1862
Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
(cherry picked from commit c76d495612)

Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2151>
2026-04-09 08:59:09 +00:00
.gitlab-ci CI: update libdecor from 0.1.0 to 0.1.1 2024-09-24 11:33:02 +02:00
composite composite: initialize border clip even when pixmap alloc fails 2025-02-25 19:38:11 +01:00
damageext Remove autotools support 2021-10-27 13:15:40 +03:00
dbe Drop Xorg DDX 2024-04-12 10:40:05 +02:00
dix dix: avoid null ptr deref at doListFontsAndAliases 2026-04-09 08:59:09 +00:00
doc dix: dixutils: make workQueue pointer dix-private 2024-02-23 23:06:38 +00:00
dri3 Drop Xorg DDX 2024-04-12 10:40:05 +02:00
fb Drop Xorg DDX 2024-04-12 10:40:05 +02:00
glamor glamor: avoid double free in glamor_make_pixmap_exportable() 2026-04-09 08:59:08 +00:00
glx Drop Xorg DDX 2024-04-12 10:40:05 +02:00
hw Revert "xwayland: Call register_damage depending on ensure_surface_for_window" 2026-04-09 08:59:09 +00:00
include xkb: Make the RT_XKBCLIENT resource private 2025-10-28 14:27:03 +01:00
man Drop Xorg DDX 2024-04-12 10:40:05 +02:00
mi mi: guard miPointer functions against NULL dereferences 2025-04-08 10:03:30 +02:00
miext meson: fix build if shmfence is enabled but dri3 & xwayland are not 2025-10-21 08:56:39 +02:00
os os: make FormatInt64() handle LONG_MIN correctly 2026-04-09 08:59:09 +00:00
present present: Fix use-after-free in present_create_notifies() 2025-10-28 14:27:03 +01:00
randr randr: clear primary screen's primaryOutput when the output is deleted 2026-04-09 08:59:09 +00:00
record record: Check for overflow in RecordSanityCheckRegisterClients() 2025-06-17 15:08:10 +02:00
render render: fix multiple mem leaks on err paths 2026-04-09 08:59:09 +00:00
test test: Fix xsync test 2025-02-25 19:38:08 +01:00
Xext panoramix: avoid null dereference in PanoramiXConsolidate() 2026-04-09 08:59:08 +00:00
xfixes xfixes: Check request length for SetClientDisconnectMode 2025-06-17 15:07:52 +02:00
Xi Xi: handle allocation failure in add_master_func() 2025-10-21 08:56:39 +02:00
xkb xkb: Fix serialization of key type without level names 2026-04-09 08:59:09 +00:00
.appveyor.yml Drop Xephyr / kdrive DDX 2024-04-12 10:40:05 +02:00
.dir-locals.el .dir-locals.el: Add missing final newline 2019-10-01 17:05:28 +00:00
.gitignore Clean up the .gitignore file 2024-01-12 00:50:24 +00:00
.gitlab-ci.yml CI: update libdecor from 0.1.0 to 0.1.1 2024-09-24 11:33:02 +02:00
.mailmap Add a .mailmap file to canonicalize author names and emails 2023-03-15 18:10:51 +00:00
COPYING COPYING: add author to HPND-sell-MIT-disclaimer-xserver 2026-04-09 08:59:09 +00:00
meson.build meson: don't build xselinux if xace is disabled 2026-04-09 08:59:08 +00:00
meson_options.txt meson: Build Xwayland unconditionally 2024-04-12 10:40:05 +02:00
README.md Fix spelling/wording issues 2020-07-05 13:07:33 -07:00
SECURITY.md xwayland: Expunge the SECURITY.md file 2026-04-09 08:59:08 +00:00
xserver.ent.in doc: relocate xserver.ent in the package root directory 2011-05-14 11:22:26 -07:00

X Server

The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.

Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.

For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server

All questions regarding this software should be directed at the Xorg mailing list:

https://lists.freedesktop.org/mailman/listinfo/xorg

The primary development code repository can be found at:

https://gitlab.freedesktop.org/xorg/xserver

For patch submission instructions, see:

https://www.x.org/wiki/Development/Documentation/SubmittingPatches

As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc:

https://www.freedesktop.org/wiki/CodeOfConduct