Find a file
Peter Hutterer 1e84784554 Xi/randr: fix handling of PropModeAppend/Prepend
The handling of appending/prepending properties was incorrect, with at
least two bugs: the property length was set to the length of the new
part only, i.e. appending or prepending N elements to a property with P
existing elements always resulted in the property having N elements
instead of N + P.

Second, when pre-pending a value to a property, the offset for the old
values was incorrect, leaving the new property with potentially
uninitalized values and/or resulting in OOB memory writes.
For example, prepending a 3 element value to a 5 element property would
result in this 8 value array:
  [N, N, N, ?, ?, P, P, P ] P, P
                            ^OOB write

The XI2 code is a copy/paste of the RandR code, so the bug exists in
both.

CVE-2023-5367, ZDI-CAN-22153

This vulnerability was discovered by:
Jan-Niklas Sohn working with Trend Micro Zero Day Initiative

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit 541ab2ecd4)
2023-10-25 11:49:11 +10:00
.gitlab-ci meson: Change project name to xwayland 2023-07-18 12:52:07 +00:00
composite Drop Xorg DDX 2023-07-18 12:52:07 +00:00
damageext Remove autotools support 2021-10-27 13:15:40 +03:00
dbe Drop Xorg DDX 2023-07-18 12:52:07 +00:00
dix Drop config directory 2023-07-18 12:52:07 +00:00
doc Remove autotools support 2021-10-27 13:15:40 +03:00
dri3 Drop Xorg DDX 2023-07-18 12:52:07 +00:00
fb Drop Xorg DDX 2023-07-18 12:52:07 +00:00
glamor glamor: xv: Fix invalid accessing of plane attributes for NV12 2023-10-12 09:39:54 +02:00
glx Drop Xorg DDX 2023-07-18 12:52:07 +00:00
hw xwayland: Cancel the EI disconnect timer when freed 2023-10-12 09:40:04 +02:00
include Switch to libbsd-overlay 2023-10-23 23:45:09 -04:00
m4 Add ax_pthread.m4 to m4/ 2016-05-29 19:20:51 -07:00
man Disallow byte-swapped clients by default 2023-01-06 11:59:37 +10:00
mi mi: Fix up alpha channel if needed in miPaintWindow 2023-07-27 16:50:36 +02:00
miext Drop miext/shadow directory 2023-07-18 12:52:07 +00:00
os Switch to libbsd-overlay 2023-10-23 23:45:09 -04:00
present Drop Xorg DDX 2023-07-18 12:52:07 +00:00
randr Xi/randr: fix handling of PropModeAppend/Prepend 2023-10-25 11:49:11 +10:00
record record: Fix out of bounds access in SwapCreateRegister() 2021-12-14 15:00:00 +02:00
render Drop Xorg DDX 2023-07-18 12:52:07 +00:00
test Drop Xephyr / kdrive DDX 2023-07-18 12:52:07 +00:00
Xext xtest: Check whether there is a sendEventsProc to call 2023-09-19 11:14:59 +02:00
xfixes Remove "All rights reserved" from Oracle copyright notices 2023-02-25 09:40:41 -08:00
Xi Xi/randr: fix handling of PropModeAppend/Prepend 2023-10-25 11:49:11 +10:00
xkb ddxLoad: Check XDG_RUNTIME_DIR before fallback to /tmp/ 2023-04-06 00:48:12 +00:00
.appveyor.yml Drop Xephyr / kdrive DDX 2023-07-18 12:52:07 +00:00
.dir-locals.el .dir-locals.el: Add missing final newline 2019-10-01 17:05:28 +00:00
.gitignore .gitignore: Add new autotools file 'test-driver' 2014-04-21 13:41:42 -07:00
.gitlab-ci.yml Drop Xwin DDX and x86 MinGW-w64 cross build 2023-07-18 12:52:07 +00:00
.mailmap Add a .mailmap file to canonicalize author names and emails 2023-03-15 18:10:51 +00:00
COPYING modesetting: Merge modesetting's COPYING into the xserver's. 2014-09-15 12:46:02 -07:00
meson.build Switch to libbsd-overlay 2023-10-23 23:45:09 -04:00
meson_options.txt meson: Build Xwayland unconditionally 2023-07-18 12:52:07 +00:00
README.md Fix spelling/wording issues 2020-07-05 13:07:33 -07:00
xserver.ent.in doc: relocate xserver.ent in the package root directory 2011-05-14 11:22:26 -07:00

X Server

The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.

Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.

For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server

All questions regarding this software should be directed at the Xorg mailing list:

https://lists.freedesktop.org/mailman/listinfo/xorg

The primary development code repository can be found at:

https://gitlab.freedesktop.org/xorg/xserver

For patch submission instructions, see:

https://www.x.org/wiki/Development/Documentation/SubmittingPatches

As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc:

https://www.freedesktop.org/wiki/CodeOfConduct