The glyph bounding box in RootlessGlyphs is computed in drawable-relative (window-local) coordinates, but RootlessDamageBox expects global (screen) coordinates. Without translating by drawable.x/y, the damage region often fell outside the window's borderClip and was silently discarded by RootlessDamageRegion. RootlessGlyphs accumulated glyph positions starting from (xSrc, ySrc) instead of (0, 0). The xSrc/ySrc parameters are the source picture reference point, not destination offsets. Every standard Glyphs implementation (fbGlyphs, miGlyphs) starts position accumulation from (0, 0) and builds up destination coordinates by adding each GlyphList's xOff/yOff deltas. Starting from xSrc shifted the entire damage bounding box by (xSrc, ySrc), causing it to miss the actual rendered region. For typical text rendering where xSrc equals the destination x position, this doubled the offset, placing the damage box well outside the window's borderClip and causing RootlessDamageRegion to silently discard it. Fixes [1/2]: https://github.com/XQuartz/XQuartz/issues/323 Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com> |
||
|---|---|---|
| .gitlab-ci | ||
| composite | ||
| config | ||
| damageext | ||
| dbe | ||
| dix | ||
| doc | ||
| dri3 | ||
| exa | ||
| fb | ||
| glamor | ||
| glx | ||
| hw | ||
| include | ||
| m4 | ||
| man | ||
| mi | ||
| miext | ||
| os | ||
| present | ||
| pseudoramiX | ||
| randr | ||
| record | ||
| render | ||
| test | ||
| Xext | ||
| xfixes | ||
| Xi | ||
| xkb | ||
| .appveyor.yml | ||
| .dir-locals.el | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .travis.yml | ||
| autogen.sh | ||
| configure.ac | ||
| COPYING | ||
| devbook.am | ||
| docbook.am | ||
| Makefile.am | ||
| manpages.am | ||
| meson.build | ||
| meson_options.txt | ||
| README.md | ||
| SECURITY.md | ||
| xorg-server.m4 | ||
| xorg-server.pc.in | ||
| xserver.ent.in | ||
X Server
The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.
Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.
For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server
All questions regarding this software should be directed at the Xorg mailing list:
https://lists.freedesktop.org/mailman/listinfo/xorg
The primary development code repository can be found at:
https://gitlab.freedesktop.org/xorg/xserver
For patch submission instructions, see:
https://www.x.org/wiki/Development/Documentation/SubmittingPatches
As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc: