fdo-mirrors/xserver
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/xorg/xserver.git synced 2025-12-20 05:50:04 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
xserver/hw/vfb
History
Exact
Alan Coopersmith de6f92513b Limit the number of screens Xvfb will attempt to allocate memory for 
Commit f9e3a2955d removing the MAXSCREEN limit left the screen
number too unlimited, and allowed any positive int for a screen number:

Xvfb :1 -screen 2147483647 1024x1024x8

Fatal server error:
Not enough memory for screen 2147483647

Found by Parfait 0.3.7:
Error: Integer overflow (CWE 190)
   Integer parameter of memory allocation function realloc() may overflow due to multiplication with constant value 1112
        at line 293 of hw/vfb/InitOutput.c in function 'ddxProcessArgument'.

Since the X11 connection setup only has a CARD8 for number of SCREENS,
limit to 255 screens, which is also low enough to avoid overflow on the
sizeof(*vfbScreens) * (screenNum + 1) calculation for realloc.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Jamey Sharp <jamey@minilop.net>
(cherry picked from commit feebf67463)
2012-01-18 11:17:02 -08:00
..
man man: refactor common code in the man pages makefiles 2011-01-18 15:11:10 -08:00
.gitignore Xvfb: build Xvfb man pages using XORG_MANPAGE_SECTIONS 2011-01-18 15:10:24 -08:00
InitInput.c input: Purge Register*Device() functions. 2010-09-01 15:26:47 +10:00
InitOutput.c Limit the number of screens Xvfb will attempt to allocate memory for 2012-01-18 11:17:02 -08:00
Makefile.am Xvfb: build Xvfb man pages using XORG_MANPAGE_SECTIONS 2011-01-18 15:10:24 -08:00