mirror of
https://gitlab.freedesktop.org/xorg/xserver.git
synced 2025-12-20 04:40:02 +01:00
6b290fa5d9
We must not modify the contents of a client pixmap.
If there's an available window buffer, we re-use that for the window
pixmap. Otherwise we just allocate a new one.
This also avoids Present client hangs due to xwl_present_buffer_release
not getting called for the buffer release event.
v2:
* Use xwl_pixmap_get_buffer_release_cb instead of keeping track of the
flip pixmap in xwl_window.
* Dispose of xwl_window_buffer in xwl_window_swap_pixmap called from
damage_report.
v3:
* Use xwl_window->surface_pixmap in damage_report.
v4:
* Don't re-use client pixmaps as window buffers.
* Clear xwl_window_buffer->pixmap before calling
xwl_window_buffer_maybe_dispose in xwl_window_swap_pixmap, to prevent
it from clearing the buffer release callback.
v5:
* Keep using xwl_window_buffers_get_pixmap in xwl_window_attach_buffer.
* Always keep a reference to the old window pixmap in _swap_pixmap,
drop it in damage_report.
Fixes: 6779ec5bf6 ("xwayland: Use window pixmap as a window buffer")
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1633
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1644
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1314>
54 lines
2.1 KiB
C
54 lines
2.1 KiB
C
/*
|
|
* Copyright © 2014 Intel Corporation
|
|
*
|
|
* Permission to use, copy, modify, distribute, and sell this software
|
|
* and its documentation for any purpose is hereby granted without
|
|
* fee, provided that the above copyright notice appear in all copies
|
|
* and that both that copyright notice and this permission notice
|
|
* appear in supporting documentation, and that the name of the
|
|
* copyright holders not be used in advertising or publicity
|
|
* pertaining to distribution of the software without specific,
|
|
* written prior permission. The copyright holders make no
|
|
* representations about the suitability of this software for any
|
|
* purpose. It is provided "as is" without express or implied
|
|
* warranty.
|
|
*
|
|
* THE COPYRIGHT HOLDERS DISCLAIM ALL WARRANTIES WITH REGARD TO THIS
|
|
* SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND
|
|
* FITNESS, IN NO EVENT SHALL THE COPYRIGHT HOLDERS BE LIABLE FOR ANY
|
|
* SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN
|
|
* AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING
|
|
* OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS
|
|
* SOFTWARE.
|
|
*/
|
|
|
|
#ifndef XWAYLAND_PIXMAP_H
|
|
#define XWAYLAND_PIXMAP_H
|
|
|
|
#include <xwayland-config.h>
|
|
#include <wayland-client.h>
|
|
|
|
#include "pixmapstr.h"
|
|
|
|
/* This is an opaque structure implemented in the different backends */
|
|
struct xwl_pixmap;
|
|
|
|
typedef void (*xwl_buffer_release_cb) (void *data);
|
|
|
|
void xwl_pixmap_set_private(PixmapPtr pixmap, struct xwl_pixmap *xwl_pixmap);
|
|
struct xwl_pixmap *xwl_pixmap_get(PixmapPtr pixmap);
|
|
struct wl_buffer *xwl_pixmap_get_wl_buffer(PixmapPtr pixmap);
|
|
Bool xwl_pixmap_set_buffer_release_cb(PixmapPtr pixmap,
|
|
xwl_buffer_release_cb func, void *data);
|
|
void xwl_pixmap_del_buffer_release_cb(PixmapPtr pixmap);
|
|
void xwl_pixmap_buffer_release_cb(void *data, struct wl_buffer *wl_buffer);
|
|
Bool xwl_pixmap_init(void);
|
|
|
|
static inline Bool
|
|
xwl_is_client_pixmap(PixmapPtr pixmap)
|
|
{
|
|
return clients[CLIENT_ID(pixmap->drawable.id)] != serverClient;
|
|
}
|
|
|
|
#endif /* XWAYLAND_PIXMAP_H */
|