From fb11b95b61cc8ff3c80d1180749e11dae1cbcdf6 Mon Sep 17 00:00:00 2001 From: "Enrico Weigelt, metux IT consult" Date: Tue, 2 Apr 2024 17:10:12 +0200 Subject: [PATCH] xfree86: common: xf86Bus: fix char signess mismatch MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On NetBSD gives warning: In file included from /usr/include/ctype.h:100, from ../hw/xfree86/common/xf86Bus.c:36: ../hw/xfree86/common/xf86Bus.c: In function ‘StringToBusType’: ../hw/xfree86/common/xf86Bus.c:270:22: warning: array subscript has type ‘char’ [-Wchar-subscripts] 270 | if (isdigit(busID[0])) { | ^ Signed-off-by: Enrico Weigelt, metux IT consult Part-of: (cherry picked from commit 99017bf94882180ea178df2446bb95a684866e5c) --- hw/xfree86/common/xf86Bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/common/xf86Bus.c b/hw/xfree86/common/xf86Bus.c index cf160a791..d116a56e2 100644 --- a/hw/xfree86/common/xf86Bus.c +++ b/hw/xfree86/common/xf86Bus.c @@ -267,7 +267,7 @@ StringToBusType(const char *busID, const char **retID) BusType ret = BUS_NONE; /* If no type field, Default to PCI */ - if (isdigit(busID[0])) { + if (isdigit((unsigned char)busID[0])) { if (retID) *retID = busID; return BUS_PCI;