fdo-mirrors/xserver
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/xorg/xserver.git synced 2025-12-20 02:20:03 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

dri: prevent out-of-bounds read in dri3_fd_from_pixmap

Browse source 
Reported in #1817:

xwayland-24.1.6/redhat-linux-build/../dri3/dri3_screen.c:143:13:
 warning[-Wanalyzer-out-of-bounds]: stack-based buffer over-read
xwayland-24.1.6/redhat-linux-build/../dri3/dri3_screen.c:143:13:
 danger: out-of-bounds read from byte 16 till byte 19
 but ‘fds’ ends at byte 16
141|           int i;
142|           for (i = 0; i < num_fds; i++)
143|->             close(fds[i]);
144|           return -1;
145|       }

Only possible if fds_from_pixmap returns a value > 4, but the analyzer
doesn't know the interface is defined not to do that.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2085>
This commit is contained in:
Alan Coopersmith 2025-10-25 14:09:39 -07:00 • committed by Marge Bot
parent 475d9f49ac
commit f05f269f1d
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
dri3/dri3_screen.c
View file

@ -138,9 +138,10 @@ dri3_fd_from_pixmap(PixmapPtr pixmap, CARD16 *stride, CARD32 *size)
num_fds = info->fds_from_pixmap(screen, pixmap, fds, strides, offsets, num_fds = info->fds_from_pixmap(screen, pixmap, fds, strides, offsets,
&modifier); &modifier);
if (num_fds != 1 || offsets[0] != 0) { if (num_fds != 1 || offsets[0] != 0) {
int i; for (int i = 0; i < num_fds; i++) {
for (i = 0; i < num_fds; i++) BUG_RETURN_VAL(i >= ARRAY_SIZE(fds), -1);
close(fds[i]); close(fds[i]);
}
return -1; return -1;
} }