From eca5de2f1a08b38cf17188c8b3d02bae7fc14cd5 Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Mon, 25 Jun 2012 14:24:11 +1000 Subject: [PATCH] dix: fix memory leak in TouchEventHistoryReplay Don't leak if ti->history is NULL. Found by coverity. Signed-off-by: Peter Hutterer Reviewed-by: Dave Airlie (cherry picked from commit a9c09f8f8e2a97e4bfe927bc4c7f29b04ee3403a) --- dix/touch.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/dix/touch.c b/dix/touch.c index 401cb981a..04733ab35 100644 --- a/dix/touch.c +++ b/dix/touch.c @@ -460,14 +460,17 @@ TouchEventHistoryPush(TouchPointInfoPtr ti, const DeviceEvent *ev) void TouchEventHistoryReplay(TouchPointInfoPtr ti, DeviceIntPtr dev, XID resource) { - InternalEvent *tel = InitEventList(GetMaximumEventsNum()); - ValuatorMask *mask = valuator_mask_new(0); + InternalEvent *tel; + ValuatorMask *mask; int i, nev; int flags; if (!ti->history) return; + tel = InitEventList(GetMaximumEventsNum()); + mask = valuator_mask_new(0); + valuator_mask_set_double(mask, 0, ti->history[0].valuators.data[0]); valuator_mask_set_double(mask, 1, ti->history[0].valuators.data[1]);